From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13662 invoked by alias); 11 Aug 2015 16:19:12 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36107 Received: (qmail 20902 invoked from network); 11 Aug 2015 16:19:10 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.0 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version:content-type; bh=y5mDdRZl3tWMmCVwmxJRe+OHxfgdvJlFBA9pzCJBsW0=; b=V+ELVS1/+z8hav+mrYxZpxmtjNPiQkRVH2X8o12qO3JdBH1N933g13h8ZiTsW7OxEm cydhH/IOyrKzMI/JoL5lCty0ToK+HeByEjteF6PrNvB8rCtIREXzYc+Ncgyvyq9dXdDV 1T1bngyjNDc/dLd8ttTwBdjbHBznVh9ZGtD23X/ILYEjZJh81s226p3cDOpGc2hw/fGF s8fWcG69AvO3XHubOzDFsPgiLdZVm3WAG87hlL4azWuIkBTf9VIhBMZIFrmT4CJAP2TD 8XTVELtCFh4sg+hV4zmc5v2CR30mFwmofYz3Y7LwGRcT7AwIsOpm6lbYvdR2kniNq7d3 rjrQ== X-Gm-Message-State: ALoCoQlFgwJvL3KJaLv7eVLMO8ZZZKIjOCpbahwyudbLcRqptoI/MC1xds7cDMIMF8Jj/viNOqrA X-Received: by 10.182.191.70 with SMTP id gw6mr26391682obc.46.1439309949021; Tue, 11 Aug 2015 09:19:09 -0700 (PDT) From: Bart Schaefer Message-Id: <150811091905.ZM30285@torch.brasslantern.com> Date: Tue, 11 Aug 2015 09:19:05 -0700 In-Reply-To: <20150811124536.GA5160@bunkus.org> Comments: In reply to Moritz Bunkus "Re: ssh host completion: ~/.ssh/config vs /etc/hosts" (Aug 11, 2:45pm) References: <20150810103355.GH4077@bunkus.org> <150810125039.ZM1691@torch.brasslantern.com> <20150811124536.GA5160@bunkus.org> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: ssh host completion: ~/.ssh/config vs /etc/hosts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Aug 11, 2:45pm, Moritz Bunkus wrote: } } > It seems a bit odd that this kicks in when there is no user-name part } > in the word being completed. } } Even adding user@ I would expect all possible hosts to be listed, not } just the ones from /etc/hosts... To me the current behavior looks like a } bug. Why should entries from /etc/hosts be exclusive in any shape or } form? What makes them more special? It's not (intended to be) /etc/hosts that's special, rather it's meant to be the values in the user's explicit zstyles. It just happens that the "hosts" style has a default completion function _hosts, so that is run by _combination, and _ssh_hosts has no way to know that the results came from that default rather than from the literal styles. This is the "[case] where this gives less than optimum behaviour" that PWS speculated about in the patch in users/11333.