From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4205 invoked by alias); 12 Aug 2015 19:00:09 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36135 Received: (qmail 29346 invoked from network); 12 Aug 2015 19:00:06 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.0 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version:content-type; bh=JR0nLkP/eqTmtqKe56c2vWDDgYozfVLzMDB9TjJ9E5Q=; b=RtTzMW2R2cQU75XgRuF0g0IciqAYxDhh1WixUy3o4PmlTotopZp7V5c1GuAFNazp+W PF0h/X3n1PlNhbqTxHzPizD5MiNagD2DhchJmpaf8edNRE9UezuohHnEt1oawIxyTluR Kn87NXd+n6YgVqJci8uLNaB263nfzm6qlPpDWCGKe/u9FgzK45T0V4oRYIHTPU6dDk5r xUSGIhUXcjSqyRM6li5x5jpb4YVKPtfAXcQ7NQCmD/VLlsKmTyRiL0jQ+Ip5IQLckl0U d78kCwMKS0wOiry7ZqI7OlMJmd7og5WphGAkYrpYmXyKPC1TUMJvo+qqN1o8Ww2xVtUH rNxg== X-Gm-Message-State: ALoCoQl+eTMljzY2AcehJXaxXTFvq7Ckle01TtsSkQhNGEPlNRLd8q3pfFBn4plmMIzzzY12TfNU X-Received: by 10.202.91.2 with SMTP id p2mr19462939oib.92.1439406002723; Wed, 12 Aug 2015 12:00:02 -0700 (PDT) From: Bart Schaefer Message-Id: <150812115958.ZM14070@torch.brasslantern.com> Date: Wed, 12 Aug 2015 11:59:58 -0700 In-Reply-To: Comments: In reply to Mikael Magnusson "Re: PATCH 3/5: _imagemagick: complete all files if image files didn't match" (Aug 12, 8:12pm) References: <1439348703-8268-1-git-send-email-mikachu@gmail.com> <1439348703-8268-3-git-send-email-mikachu@gmail.com> <7518.1439400015@thecus.kiddle.eu> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh workers Subject: Re: PATCH 3/5: _imagemagick: complete all files if image files didn't match MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Aug 12, 8:12pm, Mikael Magnusson wrote: } Subject: Re: PATCH 3/5: _imagemagick: complete all files if image files di } } > You might want to instead check your file-patterns styles to see what } > you've configured that broke this. } } You're right that it works in zsh -f, however, I don't have any } file-patterns styles set and it still doesn't work in my setup. } } This is the line that breaks the desired behaviour, } zstyle ':completion:*' list-dirs-first true } } Which I find to be somewhat unexpected. I'd swear a similar conversation went by on the list sometime in the past, but I can't find it now. } This seems to fix it, and brings the l-d-f case in line with the } default case below it. I don't know that I feel strongly about this one way or another, but according to http://www.zsh.org/mla/workers/2008/msg01119.html you are not supposed to get an all-files tag when using list-dirs-first. Instead you're always supposed to get "directories" and "other-files". So instead of pats=( " *(-/):directories:directories ${glob//:/\\:}:globbed-files" '*:all-files' ) (which BTW had a stray line break in the patch you sent) it should be at most pats=( " *(-/):directories:directories ${glob//:/\\:}:globbed-files" '*(-^/):other-files' )