From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-36139-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 2999 invoked by alias); 12 Aug 2015 20:57:30 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 36139
Received: (qmail 27895 invoked from network); 12 Aug 2015 20:57:29 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,
	RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no
	version=3.4.0
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version:content-type;
        bh=TRUDSMC43H8rvpd6948qLcdzj0yXnRnMRfKHs0O/cEs=;
        b=K1oOrvTkZa9Wn67Jhuhpxa3zjHLY0YI22tv8vlpyWrWhCMhkeblQCFcJptTrAV0aVD
         f8Rb85Aes3D3Yx6T90b7QZwRywqo74aMJhKPrQvkTPsOodVBRa0kaW/wPfdpFL6/g+ou
         bSDW/+IVM2+NvDMkE/E6uGSY4sqfTAfAXLgNQCC2NxriUalTniOa1nPJwwcVhQmcI5dQ
         AS/CGOWXDW3Pk/Fhx976iS6oUjD1XsokDECubDAU0uwkdGjhpl/08gmt5AHHNhLvbTW5
         CDjZpz85U++6FCzp4q9ggFDVkIig3WAoyNdztgI71KjphSiWF3BujH53Q49LQZBVJqOW
         +inQ==
X-Gm-Message-State: ALoCoQkQYPgxzoZchpqvr+2tkz+1G42PKqEPpeVoNpyVUb5y5T3yuyF5hf/AHaJD0Fo64zTcfweg
X-Received: by 10.182.213.227 with SMTP id nv3mr31679745obc.10.1439413047325;
        Wed, 12 Aug 2015 13:57:27 -0700 (PDT)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <150812135724.ZM14165@torch.brasslantern.com>
Date: Wed, 12 Aug 2015 13:57:24 -0700
In-Reply-To: <CAHYJk3Ri8KYrG4NptQSCNaLsBP6CWBQ=XG2WQC5dCnzCNWiBgA@mail.gmail.com>
Comments: In reply to Mikael Magnusson <mikachu@gmail.com>
        "Re: PATCH 3/5: _imagemagick: complete all files if image files didn't match" (Aug 12, 10:05pm)
References: <1439348703-8268-1-git-send-email-mikachu@gmail.com> 
	<1439348703-8268-3-git-send-email-mikachu@gmail.com> 
	<7518.1439400015@thecus.kiddle.eu> 
	<CAHYJk3SUp2bj35KBdrkpvB+P3CnGASLzuHd8NQ+RFt0u3ZsaPw@mail.gmail.com> 
	<150812115958.ZM14070@torch.brasslantern.com> 
	<CAHYJk3Ri8KYrG4NptQSCNaLsBP6CWBQ=XG2WQC5dCnzCNWiBgA@mail.gmail.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH 3/5: _imagemagick: complete all files if image files didn't match
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Aug 12, 10:05pm, Mikael Magnusson wrote:
} Subject: Re: PATCH 3/5: _imagemagick: complete all files if image files di
}
} > pats=( " *(-/):directories:directories ${glob//:/\\:}:globbed-files" '*(-^/):other-files' )
} 
} I just went to send a new patch with this change, and noticed that the
} existing else case for */* does this (under list-dirs-first),
} 
}   elif [[ "$type" = */* ]] then
}     pats=( '*(-/):directories ' '*:all-files ' )
} 
} should this not be other-files too?

I've lost track of the significance of "$type" here.  It's derived from
the argument to the -g option.  Perhaps list-dirs-first is only meant
to apply to local directories, not to those found somewhere down the
tree?  It's not documented that way, though.

I think we'd have to try it and see whether it makes any difference.