From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15106 invoked by alias); 26 Aug 2015 18:07:11 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36282 Received: (qmail 10161 invoked from network); 26 Aug 2015 18:07:09 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version:content-type; bh=/kmL9Y2FzjJVnFI1u+rcRUBIC3OmFWMzrrqWHt8j/QI=; b=PNerlHC1EsyBcFCi2sRcyu7DzQwoJRn9sPArrQ4h6MTyViHv37cZ3WHoAJDn7RX45G 5UwFC8w09heyWxAjJiWd9H/rg27CwLM1ijhQh0+9FWTrTBWrMk/qvv/KIvImuSZbS9Tw iXhw75sQiRuD2ecQn4FqvNHB8PEUcORLgR+2sULcQnY1uffQn7ujrJNbWONBP7RnTTNY 5zvxFSiJAVY/MPpx5D9gt6UswikRQT6Z7HnhVrMAg2vFZmA3/kQjK+9t9OvWIwPi7Os7 tPwU0DXGiLrppV7I7AguyfuDkKyeuFh23sYcv1Imbz647l+tlq2N06p10rQdogQERPkN 0o/A== X-Gm-Message-State: ALoCoQmIgFhXNlby91GdxY1Gaj0+SVER+4FhhOKkPZ6/IUtgWPbS0tHHYN6YLFB3CQJr7iRuZIdQ X-Received: by 10.182.231.194 with SMTP id ti2mr16805169obc.80.1440612425672; Wed, 26 Aug 2015 11:07:05 -0700 (PDT) From: Bart Schaefer Message-Id: <150826110702.ZM23706@torch.brasslantern.com> Date: Wed, 26 Aug 2015 11:07:02 -0700 In-Reply-To: <20150826135819.GO9970@sym.noone.org> Comments: In reply to Axel Beckert "Testsuite failures in A05execution inside Jenkins, but not locally (was: zsh 5.0.8.-test-3)" (Aug 26, 3:58pm) References: <20150825194807.194b3bed@ntlworld.com> <20150826135819.GO9970@sym.noone.org> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: Axel Beckert , zsh-workers@zsh.org Subject: Re: Testsuite failures in A05execution inside Jenkins, but not locally (was: zsh 5.0.8.-test-3) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Aug 26, 3:58pm, Axel Beckert wrote: } } But I had test suite failures when being build inside a Jenkins job. } Doesn't seem to be caused by the zsh updated though as the most recent } 5.0.8 build failed at the very same test: } } + (eval):printf:4: write error: broken pipe } + (eval):4: write error: inappropriate ioctl for device } + cat: write error: Broken pipe } + hang:printf: write error: broken pipe } + hang: write error: inappropriate ioctl for device } Was testing: Bug regression: piping a shell construct to an external process may hang Those broken pipe errors are irrelevant to the test (in fact they're the expected reason for the printf and cat processes to terminate, but under normal circumstances that doesn't print an error). So I think we can safely throw them away. Consequently, does this fix it? diff --git a/Test/A05execution.ztst b/Test/A05execution.ztst index d5501bb..d9e6409 100644 --- a/Test/A05execution.ztst +++ b/Test/A05execution.ztst @@ -207,7 +207,7 @@ F:This similar test was triggering a reproducible failure with pipestatus. coproc { read -et 5 || { print -u $ZTST_fd KILLED; kill -HUP -$$ } } print -u $ZTST_fd 'This test takes 5 seconds to fail...' { printf "%d\n" {1..20000} } | ( read -e ) - hang(){ printf "%d\n" {2..20000} | cat }; hang | ( read -e ) + hang(){ printf "%d\n" {2..20000} | cat }; hang 2>/dev/null | ( read -e ) print -p done read -et 6 -p 0:Bug regression: piping a shell construct to an external process may hang