zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: attr module compile failure
Date: Thu, 27 Aug 2015 19:00:17 -0700	[thread overview]
Message-ID: <150827190017.ZM1994@torch.brasslantern.com> (raw)
In-Reply-To: <CAHYJk3QAm1d7zdQC7rA5eHfAJg1VJUtzCy_LqzFRCACODOcSxA@mail.gmail.com>

On Aug 27,  8:58pm, Mikael Magnusson wrote:
}
} -#include "attr.mdh"
} -#include "attr.pro"
} -
}  #include <sys/types.h>
}  #include <sys/xattr.h>
} 
} +#include "attr.mdh"
} +#include "attr.pro"

So attr.mdh has #include ../../zsh.mdh -- it must be the case that
something included by zsh.mdh has an order dependency with xattr.h.

I looked at the libcap header diffs from 2.22 -> 2.23 -> 2.24 and
the only thing I can see that might be related is that capability.h
no longer includes xattr.h (if I'm reading the diff correctly).  But
that doesn't seem to have anything directly to do with XATTR_CREATE.

Swapping the order doesn't seem to break anything with older libcap,
I'd say go ahead and commit this.

-- 
Barton E. Schaefer


      reply	other threads:[~2015-08-28  2:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 18:58 Mikael Magnusson
2015-08-28  2:00 ` Bart Schaefer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150827190017.ZM1994@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).