From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14781 invoked by alias); 28 Aug 2015 02:00:24 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36311 Received: (qmail 6882 invoked from network); 28 Aug 2015 02:00:22 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version:content-type; bh=Nb18j1qBBS+uTjWtd4HEeH7B2fLURBNis+D7Fau8C7I=; b=VbiwbLUtnp3M9AJDXmghG8JbdxzP3ov5epxthQDsfvZlERGCpvfDiStus8uoWi7lE4 mxVdwz1PEUYIJQrqD7PfLZ7pWmgL5zmUV2+ZM8sPtt8Le7X5K+Q1N3wKdbbpy51dSfGu fkAe5J8mJ1moEEdEkFjMqll6uvdS4oFPq3volFlBKbhR+iSosvWg6Dx9ELkT4PIuHNWz 6ZFW7xMtOMZES/PCZlk0ci1+Obt8NCS7qMp8VDGw8JmtE4gb9D2n8WARCDlquwnVzKCv c1qF7yQ5d4A9juDjdO0dqCtDx8Bey93/vgJlw+uygluagO7L2tne3Kbs/qwsbKv3r0IF adqA== X-Gm-Message-State: ALoCoQlxzDEwn25Rb1dKo22dWXz1O4w7A3ZFUjMLzRH6ISi2nKWGJANawlPvClj51dE9G7QjrS3O X-Received: by 10.60.65.68 with SMTP id v4mr4343048oes.84.1440727220490; Thu, 27 Aug 2015 19:00:20 -0700 (PDT) From: Bart Schaefer Message-Id: <150827190017.ZM1994@torch.brasslantern.com> Date: Thu, 27 Aug 2015 19:00:17 -0700 In-Reply-To: Comments: In reply to Mikael Magnusson "attr module compile failure" (Aug 27, 8:58pm) References: X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh workers Subject: Re: attr module compile failure MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Aug 27, 8:58pm, Mikael Magnusson wrote: } } -#include "attr.mdh" } -#include "attr.pro" } - } #include } #include } } +#include "attr.mdh" } +#include "attr.pro" So attr.mdh has #include ../../zsh.mdh -- it must be the case that something included by zsh.mdh has an order dependency with xattr.h. I looked at the libcap header diffs from 2.22 -> 2.23 -> 2.24 and the only thing I can see that might be related is that capability.h no longer includes xattr.h (if I'm reading the diff correctly). But that doesn't seem to have anything directly to do with XATTR_CREATE. Swapping the order doesn't seem to break anything with older libcap, I'd say go ahead and commit this. -- Barton E. Schaefer