From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18244 invoked by alias); 19 Oct 2017 18:24:15 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 41940 Received: (qmail 15128 invoked by uid 1010); 19 Oct 2017 18:24:15 -0000 X-Qmail-Scanner-Diagnostics: from out4-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.28):SA:0(-2.6/5.0):. Processed in 1.279825 secs); 19 Oct 2017 18:24:15 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=y49sKW twkLRXo64tYGEBViS1/ngPCyJGpRb4ltxy/rs=; b=Jzc8pV/6ta7Xv9Vq1XssRJ K9dZljTu4Wh+9iwEJHK9I8xXncLTY6qebmVykQQ10VcQJ+UVGYi9gdBWTiqNEl0N EQdYI/fdtGeQOD8tj8RonqViJk5VOJB7EKQ+QN+4txD06XMRUwuzw4tpbXLsQq5P 5efxwdTRdOj0VMQNTGIG0xh+ngqraix9V+qgJBM5Gs6e/eHuu2y5buqHtwmPl5y1 UBKW+PCkNKD84vFQ9vbPl+BSpvpGOoRcp7L1WZVhv4Wh8dVOMu5wF4fX5LOTNL8I oYxOy/YqSEjgbJDXBVi1gqwJCLQC4lBXLNti0e7LAUpmeT4btd9KF8NMFs62VZdw == DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=y49sKW twkLRXo64tYGEBViS1/ngPCyJGpRb4ltxy/rs=; b=IQ8WBSdr1d4LR2Me4Hebwm yQvZBw6BSdI3v3VfnBmVJ62Jbpo7fCh8TKF2QfUUdxiTL6tIZoT2SMboT6uUhbp2 7fnCTzsH0RFz7Tu95lBNpQAyfiNrO1TOmThSzrL/EjOtmFoE1cGuqov3noreAtLy NyTKRuA43wEjDF4s4fpTzPBgZJ5UWSgstW+h0tS2192N4XspRpKAR/hGDvQ/b/1l ivbQj4OvUku2K6CzvRPdOZxwqF/dR0m8algziuDj3AQ6nJv9rFv2qDbcmW6t4JVn jvRw4g3rbogTaj8KzYhqvljG7yu7qnMZZVSefH4JGUZ6Tn7WyCYQO1km3/3OzaOg == X-ME-Sender: Message-Id: <1508437451.2315004.1144515592.1A7F0262@webmail.messagingengine.com> From: Daniel Shahaf To: zsh-workers@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-26fdae60 In-Reply-To: <20171019144043.pjinc3niymb6ioh4@tarpaulin.shahaf.local2> Subject: Re: [PATCH] Make typeset -p1 work in combination with -m. Date: Thu, 19 Oct 2017 18:24:11 +0000 References: <20171017182700.28303-1-danielsh@tarpaulin.shahaf.local2> <20171018093119.5c82eaa0@pwslap01u.europe.root.pri> <20171019144043.pjinc3niymb6ioh4@tarpaulin.shahaf.local2> Daniel Shahaf wrote on Thu, 19 Oct 2017 14:40 +0000: > Peter Stephenson wrote on Wed, Oct 18, 2017 at 09:31:19 +0100: > > On Tue, 17 Oct 2017 18:27:00 +0000 > > Daniel Shahaf wrote: > > > The PRINT_INCLUDEVALUE codepath will now pass > > > PRINT_LINE|PRINT_TYPESET|PRINT_INCLUDEVALUE; is that correct? > > > > Yes, as long as the resulting output makes sense the flag can be passed > > through. > > Ack. I'll double check the output before pushing. There's an unwanted output change: before% typeset -m argv argv=( ) after% typeset -m argv array argv It persists even if I strip the PRINT_TYPESET bit at the PRINT_INCLUDEVALUE callsite. Hopefully this rings a bell to someone? It looks like some issue with the PRINT_* flags. In the meantime here's a regression test. Daniel diff --git a/Test/B02typeset.ztst b/Test/B02typeset.ztst index 996af064f..3aea55d4c 100644 --- a/Test/B02typeset.ztst +++ b/Test/B02typeset.ztst @@ -794,6 +794,10 @@ 1:Mixed syntax with [key]=val not allowed for hash. ?(eval):1: bad [key]=value syntax for associative array + () { typeset -m argv } +0:typeset -m of array, without pattern matching (regression) +>argv=( ) + local -a myarray typeset -p1 myarray myarray=("&" sand '""' "" plugh)