zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Mikael Magnusson <mikachu@gmail.com>, zsh workers <zsh-workers@zsh.org>
Subject: Re: Space after if/while/for
Date: Tue, 1 Sep 2015 15:19:18 -0700	[thread overview]
Message-ID: <150901151918.ZM2379@torch.brasslantern.com> (raw)
In-Reply-To: <CAHYJk3T8J3+r943VpcUs4vYnb=KuXCjguDKV3Uv7Sj+oe+8jQQ@mail.gmail.com>

On Sep 1, 11:30pm, Mikael Magnusson wrote:
}
} Would anyone mind if I push a commit that adds the spaces (made with sed -i)?

I really prefer to avoid commits that make no semantic changes.  It's much
more difficult to see when an actual meaningful change happened (e.g. with
"git blame") when there are coding-style-only changes layered on top.


  reply	other threads:[~2015-09-01 22:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01 21:30 Mikael Magnusson
2015-09-01 22:19 ` Bart Schaefer [this message]
2015-09-01 22:20   ` Richo Healey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150901151918.ZM2379@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=mikachu@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).