From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-36385-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 14602 invoked by alias); 1 Sep 2015 23:10:08 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 36385
Received: (qmail 28111 invoked from network); 1 Sep 2015 23:10:07 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	autolearn_force=no version=3.4.0
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version:content-type;
        bh=BsiJgJeabVXZewwQUjvtinpCGrwA0R3+bsb2AB4KwWA=;
        b=BQRYDtOUa/gmoPtgRVNDdSt6s1u7rftwslQNSD3V6ClhnFUuG5ViEjoPIjrL31taXF
         lnnvNipZlsuPJMH0I6eEh8HpsSokP4dsp24QWmGK/XbSg3oZ8rg7yhZwJGTh1NO0XoG3
         +qfBKTMCwnHOmOiBmovYrRPXsbZY8N4odDesKp3nKdnNWm/5nCrjsKCRP1RAlQf0hRhb
         BcxlhyFPuxjs/S8nfkFI3rFfWlDdlr8r+BmvqOhB4EzKTKMDrXZ9snSgZqgcpCPMsP+z
         ySxVWJLeej/eIP58GfYxMjAcXbwCnwO/tU+RjS5ApwFRVhrcoqASuKTQHSiLmo1cqQ8P
         H71A==
X-Gm-Message-State: ALoCoQnddp1dkAD4taJDoztZ6/ERO9Ju4d+xnA7S0q/utRZk6gJGjXvOZwxTBSWhZXLmyygcBjyF
X-Received: by 10.60.158.161 with SMTP id wv1mr10954426oeb.55.1441149005171;
        Tue, 01 Sep 2015 16:10:05 -0700 (PDT)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <150901161002.ZM2429@torch.brasslantern.com>
Date: Tue, 1 Sep 2015 16:10:02 -0700
In-Reply-To: <20150901144527.3ee45953@pwslap01u.europe.root.pri>
Comments: In reply to Peter Stephenson <p.stephenson@samsung.com>
        "Re: [patch] "which"-builtin writes diagnostics to stdout" (Sep  1,  2:45pm)
References: <20150830030614.GB18893@frozen.localdomain> 
	<CAH+w=7aNzRtsJcvGcfyYFPAiRtNY69imSN+oGrF7K7unD5aNcA@mail.gmail.com> 
	<20150901144527.3ee45953@pwslap01u.europe.root.pri>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [patch] "which"-builtin writes diagnostics to stdout
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Sep 1,  2:45pm, Peter Stephenson wrote:
}
} This is an obvious candidate for hiding behind one of the options like
} CSH_JUNKIE_STUFF_THAT_NO_ONE_COULD_CONCEIVABLY_WANT_ANY_MORE on the
} grounds of consistency

I know we avoid this in most cases, but I'd be OK with having this
"option" be (emulation == EMULATE_CSH).

I still think the suggestion that someone might expect $(which foo) to be
the empty string is equally unlikely, or for that matter that anyone who
used $(which foo) would *want* to see the error message.  The right thing
is to test the exit status of "which".