* Fwd: [Bug 1495151] zsh completion for gphoto2 gives "--delete-files" instead of the correct "--delete-file"
@ 2015-09-12 23:53 Axel Beckert
2015-09-13 0:18 ` Bart Schaefer
0 siblings, 1 reply; 2+ messages in thread
From: Axel Beckert @ 2015-09-12 23:53 UTC (permalink / raw)
To: zsh-workers; +Cc: thuejk
Hi,
I received the following bug report via Ubuntu's Launchpad:
----- Forwarded message from Thue Janus Kristensen <thuejk@gmail.com> -----
Date: Sat, 12 Sep 2015 21:34:14 -0000
From: Thue Janus Kristensen <thuejk@gmail.com>
Subject: [Bug 1495151] [NEW] zsh completion for gphoto2 gives "--delete-files" instead of the correct "--delete-file"
Reply-To: Bug 1495151 <1495151@bugs.launchpad.net>
[…]
Public bug reported:
Zsh tab completion for gphoto2 has incorrect tab completion for
"--delete-file", wrongly appending an "s".
The error comes from the file
/usr/share/zsh/functions/Completion/Unix/_gphoto2
with the line
'--delete-files[delete files given in range]:range' \
ProblemType: Bug
DistroRelease: Ubuntu 15.04
Package: zsh-common 5.0.7-5ubuntu1
[…]
https://bugs.launchpad.net/bugs/1495151
[…]
----- End forwarded message -----
I can confirm this by comparing "gphoto2 --help | fgrep delete" with
Completion/Unix/_gphoto2 in git.
Here's the according patch I'd commit:
diff --git a/Completion/Unix/Command/_gphoto2 b/Completion/Unix/Command/_gphoto2
index 95d8a49..314d83e 100644
--- a/Completion/Unix/Command/_gphoto2
+++ b/Completion/Unix/Command/_gphoto2
@@ -32,7 +32,7 @@ _arguments -s \
'--get-all-raw-data[get all raw data from folder]' \
'--get-audio-data[get audio data given in range]:range' \
'--get-all-audio-data[get all audio data from folder]' \
- '--delete-files[delete files given in range]:range' \
+ '--delete-file[delete files given in range]:range' \
'--delete-all-files[delete all files in folder]' \
'(-u --upload-file)'{-u,--upload-file}'[upload a file to camera]:file:_files' \
'--capture-preview[capture a quick preview]' \
Kind regards, Axel
--
/~\ Plain Text Ribbon Campaign | Axel Beckert
\ / Say No to HTML in E-Mail and News | abe@deuxchevaux.org (Mail)
X See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber)
/ \ I love long mails: http://email.is-not-s.ms/ | http://abe.noone.org/ (Web)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Fwd: [Bug 1495151] zsh completion for gphoto2 gives "--delete-files" instead of the correct "--delete-file"
2015-09-12 23:53 Fwd: [Bug 1495151] zsh completion for gphoto2 gives "--delete-files" instead of the correct "--delete-file" Axel Beckert
@ 2015-09-13 0:18 ` Bart Schaefer
0 siblings, 0 replies; 2+ messages in thread
From: Bart Schaefer @ 2015-09-13 0:18 UTC (permalink / raw)
To: zsh-workers
On Sep 13, 1:53am, Axel Beckert wrote:
}
} Here's the according patch I'd commit:
Looks pretty obvious to me.
--
Barton E. Schaefer
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-13 0:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-12 23:53 Fwd: [Bug 1495151] zsh completion for gphoto2 gives "--delete-files" instead of the correct "--delete-file" Axel Beckert
2015-09-13 0:18 ` Bart Schaefer
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).