From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24653 invoked by alias); 17 Sep 2015 17:16:40 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36548 Received: (qmail 7339 invoked from network); 17 Sep 2015 17:16:39 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version:content-type; bh=6pMA3LR9pWuT9+fK7uOS6ZghrCLkFbLqI/B+80uoBTg=; b=kh+SGn4PSlUtnQHU4ADGTnMbMVcZV5rbruP++E9EWP6JuxsbQbn23xiamY5l7CR2T0 DBNsS5tEqyDsqmNiDVChDrYGokl6uMn9Ftn9dESc2LMAX8R9QHFXrzXYNE6WWbEAJjYJ FIQLt644R6PYgvNuOAQmLgiZegQNZLenX4cZ2MhyZMmQaSKKo0Cquwbzt2lgFXG3wNOj uox6bTLc3i+0vvxO441zTS3MkjJBE69CheW3YfNf9Uduy7RuXbOtHgc+9Dt79qOZXhO7 WFlOMrWZxjaY4EBSrVxq7Z3TviAsYUa0vb5ioiZzriNEGgo9Msdgr7qPEHquJVgwOH9t 5eRw== X-Gm-Message-State: ALoCoQkkVPzqn6DpPUEK3arKYxCmLeG7tq+lpfCHr/Y8ku/y8mrmOTxute43bb7DvqW/CjaPLiOC X-Received: by 10.202.76.66 with SMTP id z63mr228004oia.19.1442510196761; Thu, 17 Sep 2015 10:16:36 -0700 (PDT) From: Bart Schaefer Message-Id: <150917101633.ZM10051@torch.brasslantern.com> Date: Thu, 17 Sep 2015 10:16:33 -0700 In-Reply-To: <20150917075759.GA24365@x4> Comments: In reply to Markus Trippelsdorf "Two issues found with -fsanitize=undefined" (Sep 17, 9:57am) References: <20150917075759.GA24365@x4> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: Markus Trippelsdorf , zsh-workers@zsh.org Subject: Re: Two issues found with -fsanitize=undefined MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Sep 17, 9:57am, Markus Trippelsdorf wrote: } } I've build zsh trunk with -fsanitize=undefined and two issue popped up } while running the testsuite: It would be helpful if you included at least part of the output (after the "for:") to indicate WHICH tests reported these errors. } 1) } pattern.c:2645:12: runtime error: signed integer overflow: 1234567890123456789 * 10 cannot be represented in type 'long int' That one is fairly easy to recognize (the string 1234567890123456789 is in the test case itself) but this one: } compmatch.c:341:6: runtime error: null pointer passed as argument 2, which is declared to never be null} } Test ./Y02compmatch.ztst failed: output differs from expected as shown above for: Could be anything. The error indicates that "matchbuf" is NULL at the point where we expect to copy it into a new buffer, but if there is a deeper reason why that is unexpectedly NULL it would be better to fix that than to simply skip the copy.