From: Bart Schaefer <schaefer@brasslantern.com>
To: Mikael Magnusson <mikachu@gmail.com>, zsh-workers@zsh.org
Subject: Re: PATCH: Fix leak during Y shortcircuit glob qualifier
Date: Wed, 23 Sep 2015 20:12:01 -0700 [thread overview]
Message-ID: <150923201201.ZM32285@torch.brasslantern.com> (raw)
In-Reply-To: <1443045290-26615-1-git-send-email-mikachu@gmail.com>
On Sep 23, 11:54pm, Mikael Magnusson wrote:
} Subject: PATCH: Fix leak during Y shortcircuit glob qualifier
}
} The closedir(lock) is the leak I actually did see in usage, I have no
} idea if the other part is needed/harmful though. I'll commit just the
} closedir if nobody has any opinions.
Since scanner() is being called recursively, it's not clear that the
recursive call won't have already done an equivalent restoredir()
in the first two "return" cases -- but I do suspect it's needed in
the case where the closedir(lock) plugs a leak.
Is the current directory munged in the situation where you found a leak?
next prev parent reply other threads:[~2015-09-24 3:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 21:54 Mikael Magnusson
2015-09-24 3:12 ` Bart Schaefer [this message]
2015-09-24 3:38 ` Mikael Magnusson
2015-09-24 5:18 ` Bart Schaefer
2015-09-24 18:55 ` Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150923201201.ZM32285@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=mikachu@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).