zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Static link of curses module
Date: Sun, 27 Sep 2015 09:44:15 -0700	[thread overview]
Message-ID: <150927094415.ZM25752@torch.brasslantern.com> (raw)
In-Reply-To: <20150927162835.4297b94c@ntlworld.com>

On Sep 27,  4:28pm, Peter Stephenson wrote:
}
} Typically, you'd do this by editing config.modules rather than the .mdd

config.modules is generated from the .mdd and then is what gets used at
build time, so yeah.

} I'm not sure how this is supposed to work. I can see the module being
} registered automatically, but I don't see any evidence that there
} was ever a mechanism for running the request "load_module" based on
} load=yes.

Yeah, I don't think that was ever what it was intended to mean.  I think
the intent was that if the module has autoloads, then you don't have to
declare them with "zmodload -a".  It doesn't imply that load_module()
is actually called.

Look at the modules that have "load=yes" in the default .mdd file:

rlimits
sched
parameter
termcap
terminfo
zutil
(plus several in Zle)

Those all have autofeatures declared.  Then look at curses.mdd -- it
has "autobins" instead.  No other .mdd file has "autobins".

I think curses.mdd just got overlooked when we converted to the features
mechanism.  Try this?


diff --git a/Src/Modules/curses.mdd b/Src/Modules/curses.mdd
index 669c4f5..80c8f86 100644
--- a/Src/Modules/curses.mdd
+++ b/Src/Modules/curses.mdd
@@ -2,7 +2,7 @@ name=zsh/curses
 link='if test "x$ac_cv_func_initscr" = xyes && test "x$zsh_cv_path_curses_header" != x; then echo dynamic; else echo no; fi'
 load=no
 
-autobins="zcurses"
+autofeatures="b:zcurses"
 
 objects="curses.o"
 


  parent reply	other threads:[~2015-09-27 16:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-27 13:16 Sebastian Gniazdowski
2015-09-27 13:45 ` Sebastian Gniazdowski
2015-09-27 15:28 ` Peter Stephenson
2015-09-27 16:04   ` Sebastian Gniazdowski
2015-09-27 17:17     ` Sebastian Gniazdowski
2015-09-27 16:44   ` Bart Schaefer [this message]
2015-09-28  8:35     ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150927094415.ZM25752@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).