zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] Add API wrapper to ${+_comps[...]}
Date: Mon, 5 Oct 2015 15:11:48 -0700	[thread overview]
Message-ID: <151005151148.ZM4523@torch.brasslantern.com> (raw)
In-Reply-To: <20151005215134.GA1959@tarsus.local2>

On Oct 5,  9:51pm, Daniel Shahaf wrote:
} Subject: Re: [PATCH] Add API wrapper to ${+_comps[...]}
}
} Bart Schaefer wrote on Sat, Oct 03, 2015 at 17:49:19 -0700:
} > 
} > (Why two separate patches both to compsys.yo?)
} 
} One logical change per commit.

But you don't care about one logical commit per zsh-workers sequence
number?  I mean, I'm not unreasonably sticky about it, but I try to
keep it that way.

} > On the other hand there are tests for whether a particular function
} > is defined.  If that function is destined to be assigned to _comps[x]
} > perhaps it would be better to check for _comps[x] already defined
} > instead.
} 
} _comps[x] being already defined in what sense?  I can think of three
} meanings: (a) hash key exists

That sense.

The point being that if we're going to bother defining "compexists"
then maybe we ought to use it instead of (( ${+functions[_name]} )).
It couldn't replace all such tests, since in most cases those are
"helper" functions rather than values in $_comps, but perhaps some.

I'm trying to find a metric for usefulness.


  reply	other threads:[~2015-10-05 22:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30 18:29 Daniel Shahaf
2015-10-04  0:49 ` Bart Schaefer
2015-10-05 21:51   ` Daniel Shahaf
2015-10-05 22:11     ` Bart Schaefer [this message]
2015-10-05 22:33       ` Daniel Shahaf
2015-10-05 22:49         ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151005151148.ZM4523@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).