zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Bug report: zsh crashes when expanding long command from history.
Date: Tue, 20 Oct 2015 10:30:05 -0700	[thread overview]
Message-ID: <151020103005.ZM1642@torch.brasslantern.com> (raw)
In-Reply-To: <56261BBA.9000805@allegrodvt.com>

On Oct 20, 12:47pm, Dorian Haglund wrote:
}
} That means if I type something like :
} 
} '$ !8349'
} 
} and hit the TAB button, zsh crashes.

For me it exits cleanly but with "fatal error: out of heap memory"

} The command is attached (it is 41111 characters long so I won't copy 
} paste it here).

The history mechanism is using a short integer to track the position of
each word in the command line, so any command line longer than the
maximum value of a signed short is going to cause problems.

I don't have time today to dive further into this, but either we need
to change all the "short" to something larger in hist.c, or we need to
detect overflow and error out sooner, or most likely both.


  reply	other threads:[~2015-10-20 17:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20 10:47 Dorian Haglund
2015-10-20 17:30 ` Bart Schaefer [this message]
2015-10-21 22:04   ` Bart Schaefer
2015-10-21 22:16     ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151020103005.ZM1642@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).