From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22604 invoked by alias); 22 Oct 2015 15:00:31 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36915 Received: (qmail 11780 invoked from network); 22 Oct 2015 15:00:30 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version:content-type; bh=Qx23+x0NlSNa87J7PBWNgLKQpWkj+AJKjBTgM4C/V/M=; b=NlnbkcGP7fRN0YO6aH7yQdY0ojyNODksGWFsCySISi0mXQpli9jQMUYNdZEk3Ay9UG kwC8nW8P2H1VukZ9n+8tul0xu1p1jRwSNi6o5ByWJYGF79XoTSnuOo7F5fRqNugQKVEi xwnBu5A4qdBrcCgjxeuZOszKM/VA7GygWiqYkgYDGvvk+fD3f3awV/TRuVLeWZEY4zXs M6TYwGx+4NDhKwuPNyVrLjaBpFGHDLMYwr+Ed1IIVrykmKEqHd+rKQKXxaT3tuUQZyGO KVSzhyIFJr16zCwKF3JZ57tARLcIHbur285Z9weduCdzFdKgNhByldbcks7bzUg+/1uY AGAw== X-Gm-Message-State: ALoCoQknS13XWy3EzdvUZp+0qnwY2hKz1+IJIs4DJogMMKulSfvZzjx+TTSkjfxt77Y+W1j/zE1w X-Received: by 10.202.184.130 with SMTP id i124mr9615436oif.122.1445526026668; Thu, 22 Oct 2015 08:00:26 -0700 (PDT) From: Bart Schaefer Message-Id: <151022080024.ZM6471@torch.brasslantern.com> Date: Thu, 22 Oct 2015 08:00:24 -0700 In-Reply-To: Comments: In reply to Sebastian Gniazdowski "Re: Slowdown around 5.0.5-dev-0" (Oct 22, 2:49pm) References: <151010105849.ZM10144@torch.brasslantern.com> <151010170623.ZM16166@torch.brasslantern.com> <151010232045.ZM12931@torch.brasslantern.com> <151011091757.ZM27755@torch.brasslantern.com> <151011103121.ZM8814@torch.brasslantern.com> <151011142204.ZM9103@torch.brasslantern.com> <151012070105.ZM15099@torch.brasslantern.com> <151012173304.ZM15477@torch.brasslantern.com> <151013085246.ZM30504@torch.brasslantern.com> <20151014142722.282d0c5a@pwslap01u.europe.root.pri> <151014092536.ZM32511@torch.brasslantern.com> <151014095009.ZM19954@torch.brasslantern.com> <151014213224.ZM15646@torch.brasslantern.com> <151015173554.ZM30733@torch.brasslantern.com> <151019102117.ZM32700@torch.brasslantern.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: Slowdown around 5.0.5-dev-0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Oct 22, 2:49pm, Sebastian Gniazdowski wrote: } } My conclusions: } - 36834 introduces high memory usage; I would suggest to use only two } optimizations -- newheaps and zhalloc; my znavtools are instant fast } with them, what's slower is searching (wrote search_test function, } results attached) My apologies, but I'm not sure I followed all of that. Can you produce a diff against commit 8e9a68ad14655c1949b1a04d5715a5caa8c344ee that shows the situation you think is the best so far? } - still not sure why 36834 allocates much memory for the string test Seeing the aforementioned diff may provide a hint. } - newheaps makes function calls longer, but it's not a substantial } difference 14% is pretty substantial, but it's probably all gained back if the function does anything significant with local variables.