From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1448 invoked by alias); 23 Oct 2015 23:50:17 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36927 Received: (qmail 28514 invoked from network); 23 Oct 2015 23:50:16 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version:content-type; bh=xLHfD0xXTE18Ks72RgsNVGct6H3JIAc7e5xckCmzk18=; b=GYpH+BCqc+KpRJAi8pUFziqZtJ94cyji6pwbleHl+zXaOUwM2+EraOK8foLAlU2NF8 o8dTaFAoiJnf46I0+MngYB2gtgyS4ho8IDnPYPl4wzrv0Dnsvh/wV9d5chfLKBbZXytj 4784VY2ueuZAnVbkyrvgFEQYuhRLGLlKidAxYIodyjy8gHTztAgZ48EtAk3fQVXDLt3r RcZhRUmOCNLB4FIsCItDEASz7yt67cfYQkDhSFPVmpicMFsI/p2lIUpBhI+CWyx6XjfP KxTPyBdL70wDNQa8tlDNbya24ev3VSxDe38FhyEokeuj9K9wcrzcXrxJwPkxx1Y4fqL/ WAfQ== X-Gm-Message-State: ALoCoQnRpEHoTNl+NRJOMfYyur2ERbSiBJSOVYZf0sJdWBn22CAaeXFUSh0yQS7mL3218FE7fzUz X-Received: by 10.202.90.84 with SMTP id o81mr16155156oib.38.1445644210461; Fri, 23 Oct 2015 16:50:10 -0700 (PDT) From: Bart Schaefer Message-Id: <151023165006.ZM25785@torch.brasslantern.com> Date: Fri, 23 Oct 2015 16:50:06 -0700 In-Reply-To: <151023122655.ZM21177@torch.brasslantern.com> Comments: In reply to Bart Schaefer "Re: Slowdown around 5.0.5-dev-0" (Oct 23, 12:26pm) References: <151010105849.ZM10144@torch.brasslantern.com> <151010170623.ZM16166@torch.brasslantern.com> <151010232045.ZM12931@torch.brasslantern.com> <151011091757.ZM27755@torch.brasslantern.com> <151011103121.ZM8814@torch.brasslantern.com> <151011142204.ZM9103@torch.brasslantern.com> <151012070105.ZM15099@torch.brasslantern.com> <151012173304.ZM15477@torch.brasslantern.com> <151013085246.ZM30504@torch.brasslantern.com> <20151014142722.282d0c5a@pwslap01u.europe.root.pri> <151014092536.ZM32511@torch.brasslantern.com> <151014095009.ZM19954@torch.brasslantern.com> <151014213224.ZM15646@torch.brasslantern.com> <151015173554.ZM30733@torch.brasslantern.com> <151019102117.ZM32700@torch.brasslantern.com> <151022080024.ZM6471@torch.brasslantern.com> <151023122655.ZM21177@torch.brasslantern.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: Slowdown around 5.0.5-dev-0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="PART-BOUNDARY=.1151023165006.ZM25785.brasslantern.com" --PART-BOUNDARY=.1151023165006.ZM25785.brasslantern.com Content-Type: text/plain; charset=us-ascii On Oct 23, 12:26pm, Bart Schaefer wrote: } } Try the below patch against 8e9a68ad1 ? Attached are my results from running the Sebastian's tests against whatever binaries I had lying around that had zprof linked, plus zsh with workers/36926. Output attached. I then rebuilt git head (8e9a68ad) and ran the tests again. First thing to note is that the results for the string test changed by about 20% just because of running the test a second time, possibly because system state changed as a result of using mmap() for heap. However, if the results can be considered reliable anyway, note that 36926 retains most of the search_test speed, which I think is an improvement over backing out all of 36834 (Sebastian's results for zsh-newheaps-zhalloc, if I'm reading his email correctly). Also zsh-5.0.7 - zsh-5.1 use a LOT of memory for the search test, and 8e9a68ad uses almost as much for the string test, but 36926 is pretty good at keeping both in check (of course the real reason the search test is better is not mem.c but instead PWS's work in pattern.c). Also 36926 and 8e9a68ad had noticeably smaller memory footprint with the function test than 5.1 or earlier, so NEWHEAPS there is definitely worth the slight loss of speed. I don't have hard numbers to show for memory because I was watching "top" ... but each new process seems to inherit some memory from the previous one, so those mmap()ed segments are probably being shared between the parent shell (the one driving the test script) and its children? Conclusion: 36926 is a good thing. Thanks, Sebastian, for observing the memory usage issue with 36384. Can you confirm my results? -- Barton E. Schaefer --PART-BOUNDARY=.1151023165006.ZM25785.brasslantern.com Content-Description: Text Content-Type: text/plain ; name="perfresults.txt" ; charset=us-ascii Content-Disposition: attachment ; filename="perfresults.txt" X-Zm-Content-Name: perfresults.txt Pass 1: Running [zsh-5.0.7]: string_test 51764.74 Running [zsh-5.0.8]: string_test 51473.90 Running [zsh-5.1]: string_test 52185.28 Running [zsh-36926]: string_test 38504.65 Running [zsh-5.0.7]: array_test 6893.61 Running [zsh-5.0.8]: array_test 6783.31 Running [zsh-5.1]: array_test 7013.65 Running [zsh-36926]: array_test 6214.61 Running [zsh-5.0.7]: function_test 21903.79 Running [zsh-5.0.8]: function_test 23027.64 Running [zsh-5.1]: function_test 22488.52 Running [zsh-36926]: function_test 30285.55 Running [zsh-5.0.7]: search_test 8359.19 Running [zsh-5.0.8]: search_test 8626.48 Running [zsh-5.1]: search_test 8176.59 Running [zsh-36926]: search_test 4394.92 Pass 2 (added build of git head as "zsh"): Running [zsh-5.0.7]: string_test 41757.54 Running [zsh-5.0.8]: string_test 41443.93 Running [zsh-5.1]: string_test 41697.08 Running [zsh]: string_test 23052.51 Running [zsh-36926]: string_test 26685.68 Running [zsh-5.0.7]: array_test 6956.99 Running [zsh-5.0.8]: array_test 6791.33 Running [zsh-5.1]: array_test 6996.48 Running [zsh]: array_test 6273.76 Running [zsh-36926]: array_test 6326.08 Running [zsh-5.0.7]: function_test 21892.22 Running [zsh-5.0.8]: function_test 22012.86 Running [zsh-5.1]: function_test 22046.14 Running [zsh]: function_test 29858.53 Running [zsh-36926]: function_test 28719.64 Running [zsh-5.0.7]: search_test 8254.72 Running [zsh-5.0.8]: search_test 8508.30 Running [zsh-5.1]: search_test 8599.57 Running [zsh]: search_test 4402.41 Running [zsh-36926]: search_test 4244.59 --PART-BOUNDARY=.1151023165006.ZM25785.brasslantern.com--