From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-36940-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 1818 invoked by alias); 24 Oct 2015 18:43:56 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 36940
Received: (qmail 7139 invoked from network); 24 Oct 2015 18:43:56 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	autolearn_force=no version=3.4.0
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version:content-type;
        bh=e8QlGXDJNw3yRs/mrC4Un+a+G4tmDwXCquObsHXI3ks=;
        b=CHTTY/KYCe2T289jLRNgccV47KNUDGB7N4CHC2wACIcrh24NgiZrzQiRGBETQpqqfR
         3m+oOADnopi0U3TFFlMNijdbO9RjUnerXlOtJjbbUl4PSo3TrtskeSviOVQbjNaIBsYO
         RT2kHORN1vld4QmFReZU3oZu10g2UWlck743dUGVeqtnfpX8wJfzYyfPOllJXmhAcuFt
         JOi6tw4BNUHt9inBSF9D1TfQ2ckA/JD+E5veOw0Cn5dmc1GuROTrVwu2FHkQXLQcb3Q2
         kiaB0uz01/9okva9UK0TLmUK9nyORsvUwv7dSr91/JdmgtTP9hmjg0N4DbaSCSX8+LFz
         oAfg==
X-Gm-Message-State: ALoCoQm69TrYBBMFLtDF1uczzsVLxm3p8Hm1PeJKLt2V27Ey3zL7RxNY0W5kyT9GwD9Pzr4XA8mq
X-Received: by 10.202.200.140 with SMTP id y134mr18202767oif.5.1445712234230;
        Sat, 24 Oct 2015 11:43:54 -0700 (PDT)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <151024114352.ZM27626@torch.brasslantern.com>
Date: Sat, 24 Oct 2015 11:43:52 -0700
In-Reply-To: <20151024191621.7f6d71bf@ntlworld.com>
Comments: In reply to Peter Stephenson <p.w.stephenson@ntlworld.com>
        "Re: Mangement of fdtable[]" (Oct 24,  7:16pm)
References: <151015172252.ZM30709@torch.brasslantern.com> 
	<20151024191621.7f6d71bf@ntlworld.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-workers@zsh.org
Subject: Re: Mangement of fdtable[]
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Oct 24,  7:16pm, Peter Stephenson wrote:
} Subject: Re: Mangement of fdtable[]
}
} Is this the fix for tcp.c (not socket.c)?

This looks very similar to what I was contemplating, except that I had
not yet thought as far as adding another FDT_* flag.  The only other
thing I was wondering about is allowing the module to control whether
the FD is closed when entering a subshell [i.e., when exec.c calls
closem(FDT_INTERNAL)], because there is not always an execv() in that
case so simply setting CLOEXEC in the module is not enough.

} I didn't think FDT_INTERNAL was the right thing, on balance,
} as they're too public for the shell taking over management

That's true for tcp.c, but perhaps not so for e.g. db_gdbm.c.