From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-37086-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 10141 invoked by alias); 9 Nov 2015 18:16:09 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 37086
Received: (qmail 10297 invoked from network); 9 Nov 2015 18:16:06 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID
	autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=brasslantern_com.20150623.gappssmtp.com; s=20150623;
        h=from:message-id:date:in-reply-to:comments:references:to:subject
         :mime-version:content-type;
        bh=xejYbkPJYUhkIvqbQoQTa4JvfrgZkJJShkgMjvfbeH4=;
        b=Kk/Qh7MHTchKCHGYpt5n9eMhEExpuB1YYfZAfJc9iu/wl/oNOflfglN5vViYeBA9ZH
         2moRtHeRRDIyKgQxnj66IzkqQDYffTJWaNPhEENq+Z1d4ovStxOA89wevxZwKOBvd+pc
         DxJpTxav6LSnuy94zbigBNzR0D2dJr5HUxywfMkCBQ04w5GPKdigV/VQ6pNLE5lN15oU
         xdIU2daR+edt0biSG8P6XMkMlhyYEaJEmU/sCXr+/iMBmmmusOT0pjYlMxc0Ja4ojaCy
         zhGRc2etKgYZoF+RGd4xJhsPw34j2BYcHmEMGV+MQHsWxqhZ9drgIrPZWlYxuEaQGIMK
         i+hQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version:content-type;
        bh=xejYbkPJYUhkIvqbQoQTa4JvfrgZkJJShkgMjvfbeH4=;
        b=BOfVbhZdfvwZEye5mgM+bylw2AziGMd8Gw8hcYVgeaji/P2PCwJXcOrtTdf7822Jrz
         Gh09iOqeGdfHKDBiX4Flsz22JM4QP8cbgZ1OyQQbB6lq79nSVn1Bda/1FzOzV5Q1+VN9
         0kpTxSVZ3Autlelmgww5UkUzrb2kuKnsPqZFo5ijfr3mpGMkV1S1+9Cj6H8kNkdntegw
         NrTN68r8A9Usz/xkzsAFfZxu5mm47Vhj97F9/i9LbSz6BVFXE8bAMnL75c6Zald0Q2C6
         POOnPoO81PZ3IEoH7jLSzLnilWKcgqQbNtHrqpWu2QWKffONFjGEMYpqhcC90HzF8+eY
         DEKg==
X-Gm-Message-State: ALoCoQnubYASyVe8LLmoGT7dHUgzsSU7WU/KyGoFSiNPrdIphyTGnuH3N4IJNmAnksl6jHeW7QnN
X-Received: by 10.60.227.166 with SMTP id sb6mr12707650oec.25.1447092963170;
        Mon, 09 Nov 2015 10:16:03 -0800 (PST)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <151109101600.ZM780@torch.brasslantern.com>
Date: Mon, 9 Nov 2015 10:15:59 -0800
In-Reply-To: <20151109105853.2d4b7745@pwslap01u.europe.root.pri>
Comments: In reply to Peter Stephenson <p.stephenson@samsung.com>
        "Re: PATCH: zsh/param/private module" (Nov  9, 10:58am)
References: <151108140526.ZM31353@torch.brasslantern.com> 
	<20151109105853.2d4b7745@pwslap01u.europe.root.pri>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-workers@zsh.org
Subject: Re: PATCH: zsh/param/private module
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Nov 9, 10:58am, Peter Stephenson wrote:
}
} This would fit in with standard practice with modules elsewhere..
} we can't guarantee how the installer has set up config.modules
} so should probably flag it as unimplemented rather than broken.
} 
} + if ! (zmodload zsh/param/private >/dev/null 2>/dev/null); then

Semi-sequitur:

This is zsh.  Why not >& /dev/null ?

Some tests use only 2>/dev/null, others use >/dev/null 2>&1, some use
a subshell and then repeat without one (like this patch) whereas others
simply use "if zmodload ...", etc.  What's actually necessary?