From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] don't exit shell on [[ -o invalid@option ]]
Date: Mon, 20 Nov 2017 01:22:41 +0000 [thread overview]
Message-ID: <1511140961.722411.1177910864.7ECFDEB6@webmail.messagingengine.com> (raw)
In-Reply-To: <20171119195337.0a09b303@ntlworld.com>
Peter Stephenson wrote on Sun, 19 Nov 2017 19:53 +0000:
> On Sun, 19 Nov 2017 11:41:57 -0800
> Bart Schaefer <schaefer@brasslantern.com> wrote:
> > On Sat, Nov 18, 2017 at 10:22 AM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > >
> > > How about the following.
> > >
> > > It uses status 3 because status 2 currently means "syntax error in [["
> > > and I didn't want to overload that; and it uses POSIX_BUILTINS because
> > > that seemed more closely related than POSIX_IDENTIFIERS.
> >
> > For reasons I can't entirely define, it bothers me that an operation
> > to test the setting of options changes its behavior based on the
> > setting of an option.
>
Are you concerned about self-reference? I.e., that code meant to run
under any options (example: z-sy-h) wouldn't be able to test the
settedness of an option using [[ -o foo ]] because the behaviour of
that command depends on whether foo is set? (That's basically the
Liar Paradox)
I don't think that's a problem in this case, but I'm listening...
> I'm actually more worried if this *isn't* an option, given it's (in a
> more touchy feely sense) optional behaviour. Having something of that
> kind based on emulation seems a bit gross. But we do have gross syntax
> changes based on emulation, it's true, such as variables that never
> appear.
I'm quite swamped this week (in a good way) but when I get a chance I'll
finish the patch and push. (Needs more tests and a README blurb, at least)
Cheers,
Daniel
next prev parent reply other threads:[~2017-11-20 1:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 18:24 Martijn Dekker
2017-11-10 18:53 ` Eric Cook
2017-11-10 19:03 ` Martijn Dekker
2017-11-10 22:37 ` Bart Schaefer
2017-11-11 12:45 ` Peter Stephenson
2017-11-11 19:01 ` Martijn Dekker
2017-11-11 23:19 ` Bart Schaefer
2017-11-12 19:56 ` Peter Stephenson
2017-11-14 12:26 ` Daniel Shahaf
2017-11-14 13:22 ` Martijn Dekker
2017-11-14 23:52 ` Daniel Shahaf
2017-11-16 0:52 ` Martijn Dekker
2017-11-18 18:22 ` Daniel Shahaf
2017-11-19 14:46 ` Martijn Dekker
2017-11-19 19:41 ` Bart Schaefer
2017-11-19 19:53 ` Peter Stephenson
2017-11-20 1:22 ` Daniel Shahaf [this message]
2017-11-24 21:50 ` Daniel Shahaf
2017-12-03 7:28 ` Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511140961.722411.1177910864.7ECFDEB6@webmail.messagingengine.com \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).