From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-37198-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 19117 invoked by alias); 22 Nov 2015 20:30:26 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 37198
Received: (qmail 479 invoked from network); 22 Nov 2015 20:30:24 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID
	autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=brasslantern-com.20150623.gappssmtp.com; s=20150623;
        h=from:message-id:date:in-reply-to:comments:references:to:subject
         :mime-version:content-type;
        bh=p88ur0+d09PCQCOSbCguCkyegANbDB84kxmlc51PMcE=;
        b=eb9ZOlC3mCIwookg4+CAf43xjZVBxxfwrHEZxHSZl7c9F+ECcTiTDVGxyB0jbeewU4
         BF1FM9+OzNaCaIu06H5Vno9GMU0hdROgeqcouuiKKlUJGdImyDtdHl+tislVX/jBhqLY
         hV8SR7CXHV/VLZkO7BRHESu9pWAFfo7IzALN7KVW8aK10yBx5EUbBDiNprQFaT51RJ97
         yI3BKZgHIhRqlHPHCVUy7dLNz0p2o+iFKX46lfFx7MDufZk2vCmishbFY6zT3ADldDXA
         23pP4s+vQbHEtSTcoB4RduBpoyYsq40yO73/6VUz3jCg7JRvTal0idKIYCllyWTwjqR5
         F+cw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version:content-type;
        bh=p88ur0+d09PCQCOSbCguCkyegANbDB84kxmlc51PMcE=;
        b=JY2cvOMXimgxUB6yG04Ro6v/wOsTWqdNs2zRgdezEvbiek4EfxYHoukB7dCPSAesNI
         c+nb+ZPPK1H0diuWOOCCOBt4cr5Pf12pjIm8YtCgTAhRwV65knmtOOfZSFzhpjQeZFw2
         fZuEvKIdOWtrhJNQbUmKWTHBLJ7yic/rGHN7S0bfjAZOMNMnKY791IbMwP+/a50jGPLY
         7uHsUYMgHQr7lfP494AfKj1NKUkcHeEPeknLE3qcwZymoD2tuTusVBiAnzCeVoR1NPLa
         s3AbTrxvlqH9o11yhcjGJmSCUdMiDrm2kbwdHUlM3Rr4pliXYoi/OtmZJimuXMW71+DU
         vypw==
X-Gm-Message-State: ALoCoQnNip8pTvROyrED+coH3Kw5CisbHvSxgUVW4hLeQ1jyLc2wXqADK8Nu8Rnl5pJl8TfBq/Yl
X-Received: by 10.98.16.76 with SMTP id y73mr11925410pfi.151.1448224221877;
        Sun, 22 Nov 2015 12:30:21 -0800 (PST)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <151122123028.ZM11174@torch.brasslantern.com>
Date: Sun, 22 Nov 2015 12:30:28 -0800
In-Reply-To: <201511221915.tAMJFbFW006908@localhost.localdomain>
Comments: In reply to Peter Stephenson <p.w.stephenson@ntlworld.com>
        "Re: Possibly excessive WARN_CREATE_GLOBAL" (Nov 22,  7:15pm)
References: <201511221915.tAMJFbFW006908@localhost.localdomain>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-workers@zsh.org
Subject: Re: Possibly excessive WARN_CREATE_GLOBAL
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Nov 22,  7:15pm, Peter Stephenson wrote:
}
} Or do you mean it doesn't actually get set *at all*?  That should surely
} trigger an error immediately in the inner scope, shouldn't it?

It doesn't get set at all.

We come into createparam() and discover at line 878 that the parameter
already exists, which is what we want, but in spite of it being flagged
PM_SPECIAL|PM_REMOVABLE all createparam() does is toggle off the PM_UNSET
flag, which seems dubious.

(And *then* it tests PM_RESTRICTED, which it seems to me ought to come
first?  That's not related to this thread, but I wouldn't think you
should be able to change the unset-ness of a restricted parameter.)

Then we enter fetchvalue() at line 2926, which correctly returns that the
parameter does not have a value, and assignaparam() silently surrenders at
line 2929.  Maybe there should always be an error at that point, I don't
know how else we might get there.