From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26691 invoked by alias); 25 Dec 2015 08:26:46 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 37435 Received: (qmail 16351 invoked from network); 25 Dec 2015 08:26:45 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version:content-type; bh=rQNqZxeMrGJYX7FMw0V3yFqFyG2F5guOEzj+SeQ2M8Y=; b=afcTmXg85xpAk/ObQEzNWFOoXzoGjCXV/EiQXlleEU1zTGu4BjRQmbeeXr4HbLzcw+ Wdb0Ht2FRxSlMyXLGOZ+xkNhD8hkEzFuzwJ90HS/adtkP4xyISoSixeGcaw40lYkIhfk YL9nBl+PjeA8IWdzz1HI8UnpBC7AkHZX8J7MSSA0hwCa/kRNLkdcFSOwPZi+n0/rRsnx 50SQGtwryS69bTRZ94nRtgeNQ6Fbu7HPn1knRzk9W03EC3++XdPIviT8u8mondOtrGwp 9SM1SKBIRMsgcIrgVUDqYaGM1JT4n3l4aiVpwCfL2MBgzIc15mkYaWrXEKZf8abbSJ+r bQBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version:content-type; bh=rQNqZxeMrGJYX7FMw0V3yFqFyG2F5guOEzj+SeQ2M8Y=; b=WGuMxauhmC0+Of7e1qNS6CU8EW3d59B44hnVlPdzFuJPkgBofHncWVSVPhV/8Oc4gB ZRmWMXn+L9RN0XYqb+1QDpASMCJ/krzpYCRzqscyWJtIg/KLd1j77OzLVz67M7dEstVQ SDdsAJOb0J6JqjO+h6Jw2nrSZ9sUQfBpRzIie/37h8d8kaSAbDxQZjmiUFZofeBSejUl jRZA43yffKSP7OhDOuXfb4GNUptFcNV14aIg4MSzbBRsdYmrdHfv/JZmqMC5B/Sx+sXJ U/tPdaMliWpkr99MJGBmUuGQua5533DFrNMOaryepGnvbi97elV/QjkVLlwZX31V5koG qqlg== X-Gm-Message-State: ALoCoQmD2J+4lgF4SY75bdIXQcOdJDfYWMq7ifdKtjk+7MxVjf8YB6kuFMhsASBzEu82VYP7a2FE92BvrCsmNlrd8Pm50EX8sw== X-Received: by 10.98.16.80 with SMTP id y77mr42621241pfi.155.1451032003725; Fri, 25 Dec 2015 00:26:43 -0800 (PST) From: Bart Schaefer Message-Id: <151225002725.ZM32571@torch.brasslantern.com> Date: Fri, 25 Dec 2015 00:27:25 -0800 In-Reply-To: <871tad6qux.fsf@gmail.com> Comments: In reply to Christian Neukirchen "zsh exec format error with empty files" (Dec 23, 6:01pm) References: <871tad6qux.fsf@gmail.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: zsh exec format error with empty files MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Dec 23, 6:01pm, Christian Neukirchen wrote: } } % ./empty } zsh: exec format error: ./empty } } For consistency, this should just run /bin/sh as well and return 0, } like in bash, dash, busybox sh, tcsh, mksh, ksh93, posh, Byron's rc } and every tool using execvp. Hm. diff --git a/Src/exec.c b/Src/exec.c index acc867c..c4dc8e3 100644 --- a/Src/exec.c +++ b/Src/exec.c @@ -471,9 +471,10 @@ zexecve(char *pth, char **argv, char **newenvp) if ((fd = open(pth, O_RDONLY|O_NOCTTY)) >= 0) { argv0 = *argv; *argv = pth; + execvbuf[0] = '\0'; ct = read(fd, execvebuf, POUNDBANGLIMIT); close(fd); - if (ct > 0) { + if (ct >= 0) { if (execvebuf[0] == '#') { if (execvebuf[1] == '!') { for (t0 = 0; t0 != ct; t0++)