From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17760 invoked by alias); 25 Dec 2017 20:18:03 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42167 Received: (qmail 2051 invoked by uid 1010); 25 Dec 2017 20:18:03 -0000 X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.26):SA:0(-2.6/5.0):. Processed in 3.921487 secs); 25 Dec 2017 20:18:03 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ch0n3D RRNpXiGNNIDNlZf4hXvaMm6wsOokkQ8iViPjY=; b=dXuWzDZl35v1GmK972fElh ffK68g8Kn39aZyZa1EzWqqSdCPD9COGyRHu4gHyaiHYhc9aVYXio8TNChtSg4V/9 Mlol3mBkWRr1aePLSUaWvml26rc7mKjyxmKpMyvShdA3DgsmTeWSMqP4P4H8cesK 988f7CSMPDyyoM0IL0Bw6+uhRRlKF3Gq06K5VIqFRGz7yzbKqwptve5BCU225L7C /kTW+cV0Yix9Qr+0eHT+rMIHkGA0XQfYSQQzsHxZcZv0xgxS4T3wUZJIqA9UWtXv nVawn7UUP+bNiXyluuC5we2MM59fX5pavPnye9ihaZLmzpEWebGq+r3uqSXyvr0Q == DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ch0n3D RRNpXiGNNIDNlZf4hXvaMm6wsOokkQ8iViPjY=; b=Yeh6XAOhQQi5Mwllw41Vnq CA6gJVJoL+fZGDxf8YejqLe2hCbiYxuFcjKrk8Uhxd1aEdNMlO1T6jPbuUrPAJVs LwYYHa2apUemu8kaT1bL/sRTymRC0Kfa26cDCllNGYO3Fa+my1X/84xyySK0ywl8 YJdk6kiHBd5bH/09R2IxEk7CDdhkihXUtaJTPg5GcoDb0td8iDbZW98PbBnONkXK sl4hhCHcZ8hCJRUZgOR9wqaW9iGKjyaJ9nu7y3lGsGFNcGSa/qoXVhwvtkwOaUO8 XXdqrZJAbEZXXnChXciPBIaXAAUxdwlRYnYtH4k8okDrMnDq8jJp7444bb/zmk8w == X-ME-Sender: Message-Id: <1514232409.2739200.1215674320.1BF9C9E5@webmail.messagingengine.com> From: Daniel Shahaf To: Andrei Shevchuk , zsh-workers@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-bb99f02b Date: Mon, 25 Dec 2017 20:06:49 +0000 Subject: Re: PATCH: Improve Mosh completion In-Reply-To: <1510274104.17218.0@smtp.gmail.com> References: <1510274104.17218.0@smtp.gmail.com> Thanks for the ping on github. Andrei Shevchuk wrote on Fri, 10 Nov 2017 03:35 +0300: > This adds ~/.ssh/config based completion support (_ssh_hosts and=20 > _ssh_users functions and userhost state handling taken without=20 > modifications from ssh completion file), Sorry, no. https://en.wikipedia.org/wiki/Don%27t_repeat_yourself If you really need to call those two functions, break them out of _ssh into separate files: % head -n1 Completion/*/Type/_ssh_files #autoload %=20 Or =E2=80=94 depending on mosh's syntax =E2=80=94 it might be better to sim= ply invoke _ssh (directly or via _normal or one of its friends). > existing code was just wrapped into _mosh function without modifications > (except userhost state handling mentioned above). Please don't mix whitespace and functional changes: that makes the diff har= der to review. > +++ b/Completion/Unix/Command/_mosh > @@ -1,26 +1,84 @@ > + '--port=3D[specify server-side port range]:port:_sequence -n 2 -s \:= =20 > _ports' \ As you can see, your MUA mangled the patch (hard line break). You can avoid this by sending patches as attachments named *.txt. Let's continue the discussion on list; there are more eyes here. Cheers, Daniel