From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-42278-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 19839 invoked by alias); 14 Jan 2018 15:43:21 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 42278
Received: (qmail 28328 invoked by uid 1010); 14 Jan 2018 15:43:21 -0000
X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from <d.s@daniel.shahaf.name>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(66.111.4.25):SA:0(-1.9/5.0):. 
 Processed in 9.497574 secs); 14 Jan 2018 15:43:21 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID
	autolearn=ham autolearn_force=no version=3.4.1
X-Envelope-From: d.s@daniel.shahaf.name
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	daniel.shahaf.name; h=content-transfer-encoding:content-type
	:date:from:in-reply-to:message-id:mime-version:references
	:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=XAE+AH
	d1Mz5dN42SS1ReuYt6xMA8xTlWJKWOqEfDfOc=; b=FQ4BUmlDrdDXwp7af2cSqt
	16EGKQqEfpvomhnElx83tR/2rsHSBWJUXjfbV1uadupuMzNkazfGyMEI2F0ZWX5m
	6ggRX3UwY4ez5BzWdaka2rAm6xTqIAZ0RnW2KlMcrmU5eySeRZ3jiVr/4gUbsjnL
	TgYQDw4zP/ZTmJDVClgd31Y0a86IzXCvRk7aB0r8D4j1tqom/wdS2e878G+eCc5A
	LIejCJ5Hp1eQyPGQmUDNBxDRsNvmdUKURkgV7eNueYRjYamqWmrw/o95HeKWEwJR
	loN7/sHqgJtNParODUmRzusruj6m95de5CzmacJa9fshBT4M3CbRlprIKdgtPnKQ
	==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=content-transfer-encoding:content-type
	:date:from:in-reply-to:message-id:mime-version:references
	:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=XAE+AH
	d1Mz5dN42SS1ReuYt6xMA8xTlWJKWOqEfDfOc=; b=kpLmfoA4dKSJzYhBqebVEh
	KptecZjRYwAvsi9d0pJEyztt+GD3vOwCtW624JKYPbOQJI142lcR+22EBMwpoxC1
	Don/rVnev9valBm72wvwQ8vjAvn3d9Xc64szwjPwS8Lk+3GmdEdpmNvPWzBVG6lO
	CfGDJ1U+avRJMo9jM8Rai4YIHieGGyPS6Uh2Kcnk36s/rdAvZZPoeaVF19D2R5qY
	MRSqu2YrJoDVrEkOc5RYaN16AhkuXIZHKci3RllZr35pJi7IEuwZ9NufdTyTZloq
	NArDUYcPSGEKbXlmq5P1rh1urIfzgrxPbEPTfEOLvwG5Eb0pk0a0Iu0ymuB8HNnA
	==
X-ME-Sender: <xms:jXpbWoZLhcKVqiTyWB-uszxxgoyj7uA6K0FJ-p_ZjGBTvFFdFqo7dw>
Message-Id: <1515944588.1617081.1234892696.1AED867B@webmail.messagingengine.com>
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
X-Mailer: MessagingEngine.com Webmail Interface - ajax-75de3051
References: <20180114152344.12018-1-joeypabalinas@gmail.com>
 <20180114152344.12018-3-joeypabalinas@gmail.com>
In-Reply-To: <20180114152344.12018-3-joeypabalinas@gmail.com>
Subject: Re: [PATCH 2/3] jp: Use `(nil)` for empty identifier strings
Date: Sun, 14 Jan 2018 15:43:08 +0000

Joey Pabalinas wrote on Sun, 14 Jan 2018 05:23 -1000:
> +++ b/Src/params.c
> @@ -3004,6 +3004,8 @@ assignsparam(char *s, char *val, int flags)
>      int sstart, created = 0;
>  
>      if (!isident(s)) {
> +	if (!strcmp(s, ""))
> +	    s = "(nil)";
>  	zerr("not an identifier: %s", s);

How about inventing an %ls expando that emits the argument quoted, so
zerr("%ls", foo) would print ${(qq)foo} or ${(q-)foo}.  That seems easier
than updating all callsites (not just these three).

(%ls/%s by analogy with %ld/%d.)

Cheers,

Daniel