From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.dk
Subject: PATCH: Re: Correction oddity
Date: Thu, 16 Aug 2001 10:05:59 +0200 [thread overview]
Message-ID: <15227.32487.365327.798594@gargle.gargle.HOWL> (raw)
In-Reply-To: <20010816001649.1729214284@pwstephenson.fsnet.co.uk>
Peter Stephenson wrote:
> ...
>
> finds _correct_group is 3; I presume this is the index of the -J or -V
> argument in the compadd command,
>
> compadd -M m:{a-zA-Z}={A-Za-z} -M corrections \
> -X Completing corrections -M r:|[_-]=* r:|=* -D equal -
>
> and indeed it is that `-M' which should be -J or -V. Unfortunately it
> becomes -M because there's no -J or -V in the argument list, and in that
> case ${argv[(R)-*[JV]]} returns the first argument --- dunno if that's a
> bug, it doesn't seem so hot, but it's presumably not the root bug.
> Getting that test to check if the reverse match turned up something
> sensible might be a start, but I'm way out of my depth.
It's really the root bug. I didn't think of cases where there is no
-[JV] passed to compadd.
Ahem.
Bye
Sven
Index: Completion/Base/Completer/_approximate
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Base/Completer/_approximate,v
retrieving revision 1.4
diff -u -r1.4 _approximate
--- Completion/Base/Completer/_approximate 2001/08/07 10:38:36 1.4
+++ Completion/Base/Completer/_approximate 2001/08/16 08:03:05
@@ -59,7 +59,8 @@
PREFIX="(#a${_comp_correct})$PREFIX"
# fi
- (( $_correct_group )) && _correct_expl[_correct_group]=${argv[(R)-*[JV]]}
+ (( $_correct_group && $argv[(I)-*[JV]] )) &&
+ _correct_expl[_correct_group]=${argv[(R)-*[JV]]}
builtin compadd "$_correct_expl[@]" "$@"
}
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
prev parent reply other threads:[~2001-08-16 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-15 23:50 Peter Stephenson
2001-08-16 0:16 ` Peter Stephenson
2001-08-16 8:05 ` Sven Wischnowsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15227.32487.365327.798594@gargle.gargle.HOWL \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).