From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.dk
Subject: More brokenness of here-docs in `functions' output
Date: Thu, 16 Aug 2001 10:46:01 +0200 [thread overview]
Message-ID: <15227.34889.492267.4370@gargle.gargle.HOWL> (raw)
In-Reply-To: <1010816031353.ZM11237@candle.brasslantern.com>
Bart Schaefer wrote:
> Consider:
>
> threedocs() {
> cat <<EOF
> this is $path
> EOF
> cat <<\EOF
> this is $path
> EOF
> cat <<-EOF
> this is $path
> EOF
> }
>
> ...
>
> But look at the output of `functions threedocs':
>
> threedocs () {
> cat <<< 'this is $path'
> cat <<< 'this is $path'
> cat <<< 'this is $path'
> }
We want this to be nice, yes? So that we have two cases in text.c.
Bye
Sven
Index: Src/text.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/text.c,v
retrieving revision 1.6
diff -u -r1.6 text.c
--- Src/text.c 2001/06/25 16:07:53 1.6
+++ Src/text.c 2001/08/16 08:43:42
@@ -751,9 +751,15 @@
taddstr(fstr[f->type]);
taddchr(' ');
if (f->type == REDIR_HERESTR) {
- taddchr('\'');
- taddstr(bslashquote(f->name, NULL, 1));
- taddchr('\'');
+ if (has_token(f->name)) {
+ taddchr('\"');
+ taddstr(bslashquote(f->name, NULL, 2));
+ taddchr('\"');
+ } else {
+ taddchr('\'');
+ taddstr(bslashquote(f->name, NULL, 1));
+ taddchr('\'');
+ }
} else
taddstr(f->name);
taddchr(' ');
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
prev parent reply other threads:[~2001-08-16 8:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-16 3:13 Bart Schaefer
2001-08-16 8:46 ` Sven Wischnowsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15227.34889.492267.4370@gargle.gargle.HOWL \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).