file completion listing in 4.1.0-dev-2

file completion listing in 4.1.0-dev-2

[martin.ebourne]

Hi,

I've now upgraded to 4.1.0-dev-2 after a case of mistaken identity. The
long/short option grouping now works properly, which is great.

I have re-checked the completion bug I reported yesterday against
4.1.0-dev-1 (title 'Completion behaviour in 4.1.0-dev-1') and can confirm
that is still not working correctly.

Also, if I do the below, then I get the blank line in the listing as
indicated, and the cursor is left incorrectly where the '#' is (the
character is really an 'e' under the cursor). This works correctly in
zsh-4.1.0-dev-1.

% zsh -f
% autoload -U compinit
% compinit -C
% zstyle ':completion:*:default' list-colors 'no=00' 'fi=38;5;11' 'di=38;5;14' 'ln=38;5;214' 'pi=38;5;218' 'so=38;5;218' 'bd=38;5;218' 'cd=38;5;218'
'ex=38;5;10' '*.bat=38;5;10' '*.com=38;5;10' '*.cmd=38;5;10' '*.exe=38;5;10' '*.arj=38;5;15' '*.lzh=38;5;15' '*.tar=38;5;15' '*.tgz=38;5;15' '
*.taz=38;5;15' '*.Z=38;5;15' '*.z=38;5;15' '*.gz=38;5;15' '*.zip=38;5;15' '*.rpm=38;5;15' '*.deb=38;5;15' '*.a=38;5;12' '*.o=38;5;12' '*.d=38;5;12' '
*.elc=38;5;12' '*.zwc=38;5;12' '*core=01;38;5;9' '*~=38;5;245' '*.flc=38;5;245'
% setopt list_packed
% echo $COLUMNS
156
% ls <TAB>
Chang#Log       Config/     INSTALL    Makefile.in   StartupFiles/  aclocal.m4     config.h.in      config.sub*    fake            stamp-h.in
ChangeLog-3.1   Doc/        LICENCE    Misc/         Test/          aczsh.m4       config.log       configure*     install-sh*     zshconfig.ac
ChangeLog.3.0   Etc/        META-FAQ   README        Util/          config.guess*  config.modules   configure.ac   mkinstalldirs*


Completion/     Functions/  Makefile   Src/          acconfig.h     config.h       config.status*   configure.in   stamp-h

Cheers,

Martin.




This e-mail message is CONFIDENTIAL and may contain legally privileged
information.  If you are not the intended recipient you should not  read,
copy, distribute, disclose or otherwise use the information in this e-mail.
Please also telephone or fax us immediately and delete the message from
your system.  E-mail may be susceptible to data corruption, interception
and unauthorised amendment, and we do not accept liability for any such
corruption, interception or amendment or the consequences thereof.

Re: file completion listing in 4.1.0-dev-2

[Sven Wischnowsky]

martin.ebourne@arcordia.com wrote:

> Also, if I do the below, then I get the blank line in the listing as
> indicated, and the cursor is left incorrectly where the '#' is (the
> character is really an 'e' under the cursor). This works correctly in
> zsh-4.1.0-dev-1.

Oops.  It thought it needed more columns and printed two runs of
spaces instead of one.


Bye
  Sven

Index: Src/Zle/compresult.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/compresult.c,v
retrieving revision 1.41
diff -u -r1.41 compresult.c
--- Src/Zle/compresult.c	2001/08/08 07:41:04	1.41
+++ Src/Zle/compresult.c	2001/10/05 12:35:37
@@ -1717,8 +1717,11 @@
                                 ws[tcol] = len;
                             }
                         }
-                        if (width < columns)
+                        if (width < columns) {
+                            if (++tcol < tcols)
+                                tcols = tcol;
                             break;
+                        }
                     }
 		}
 	    }

-- 
Sven Wischnowsky                    wischnow@informatik.hu-berlin.de

Re: file completion listing in 4.1.0-dev-2

[martin.ebourne]

Sven,

Both this and 'Completion behaviour in 4.1.0-dev-1' now working correctly
after the patches.

Cheers,

Martin.





Sven Wischnowsky <wischnow@informatik.hu-berlin.de> on 05/10/2001 13:42:46

To:   zsh-workers@sunsite.dk
cc:
Subject:  Re: file completion listing in 4.1.0-dev-2



martin.ebourne@arcordia.com wrote:

> Also, if I do the below, then I get the blank line in the listing as
> indicated, and the cursor is left incorrectly where the '#' is (the
> character is really an 'e' under the cursor). This works correctly in
> zsh-4.1.0-dev-1.

Oops.  It thought it needed more columns and printed two runs of
spaces instead of one.


Bye
  Sven