From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: unknown user error
Date: Fri, 22 Jun 2018 19:46:00 +0000 [thread overview]
Message-ID: <1529696760.1305575.1417330600.73771C85@webmail.messagingengine.com> (raw)
In-Reply-To: <CAH+w=7as0cmdE0h2NQdSyY_sSHX+crUrB=72-HhEZcf8jfqgUg@mail.gmail.com>
Bart Schaefer wrote on Fri, 22 Jun 2018 09:52 -0700:
> On Fri, Jun 22, 2018 at 9:20 AM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> >
> > Let's expand that error message. Patch attached.
>
> Why make it "user: %s" in one ifdef-branch but "username '%s'" in the other?
The #else branch says "username" because, in that preprocessor codepath,
the argument to the (u) globqual is resolvable if it's numeric (a uid)
but not if it's a username.
The #if branch says "user" because that's what it said before the patch.
I guess I'll change it unless someone sees a reason to preserve the
exact error message.
Cheers,
Daniel
prev parent reply other threads:[~2018-06-22 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 14:48 John, Michael
2018-06-22 16:17 ` dana
2018-06-22 16:20 ` Daniel Shahaf
2018-06-22 16:52 ` Bart Schaefer
2018-06-22 19:46 ` Daniel Shahaf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1529696760.1305575.1417330600.73771C85@webmail.messagingengine.com \
--to=d.s@daniel.shahaf.name \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).