From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-43245-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 1609 invoked by alias); 6 Aug 2018 12:04:42 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 43245
Received: (qmail 6600 invoked by uid 1010); 6 Aug 2018 12:04:42 -0000
X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from <d.s@daniel.shahaf.name>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(66.111.4.25):SA:0(-2.6/5.0):. 
 Processed in 2.081102 secs); 06 Aug 2018 12:04:42 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,
	SPF_HELO_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1
X-Envelope-From: d.s@daniel.shahaf.name
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	daniel.shahaf.name; h=content-transfer-encoding:content-type
	:date:from:in-reply-to:message-id:mime-version:references
	:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=P0bDWJ
	7WXuxH1EokLDehbCEA4X+e0JEn44yYuuzJYMI=; b=KXQJWxKXFUE/IV1UH5/Z2a
	52Z5YHcpLYS+vnwx7yYNAN1Xtvh2iBkhmJN/SfiwoTO8F3sZTLJFKe8hqhgx5AyJ
	hkvHZdqIGlJvd3NbPn8MM8CFx6liX4DEVnQhkIk0otLWdVNKD8tXZ+jXAwPrF7mW
	7mCj31QKFVZHRhnLi9ZUn1MUcsyA4iy7eM4UTKPfw+teE8JQAaU5xvY+RyZQhob1
	MFl8M7dGcldHgo9o+22nWLKA8O4f3jTcXbla+l2c7Ceyfeh+gjsmeo5U5/Z40tei
	fJ+UbK+cLKqhds+1tUccqlps32fdXzcIqXB1hGhmuzv8FO+7M/JT1F25+Le+/1mw
	==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=content-transfer-encoding:content-type
	:date:from:in-reply-to:message-id:mime-version:references
	:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=P0bDWJ
	7WXuxH1EokLDehbCEA4X+e0JEn44yYuuzJYMI=; b=N9eqIz/G2EvSb+DjWh4ZH8
	8ZMjvFtl5YaL5ZOHWqFAv8dPn/Eoljg16Jbw7PQIdafzDKPcL0zz/0pbp3TThcD+
	rXWFgb1SmCkIfid3pH7Eyx6whLmxPpaJrIfBza6uVmSDbgHQ8LOc3AyPHtbc6tTz
	xJa6yjKu43pB6ScSJqz2UrEd9aYDL53wXQoGf+z6fPs7ddfG0i8rLhZeYfafU9t0
	F9AxppguA2FkyP6KVnhJdgLLGRV3CcTpatBvgzi8bbN7tVm0TDxL6eIJIUT1GnmC
	u74U0sm+WUmi2spL5uBe2V4/Bw7HtvrgIHziJcaPxw6jxkVA8K/bkfvyo6E00RdQ
	==
X-ME-Proxy: <xmx:VDloW7Xoh2vck9nPFVc62Cu0WGaRGBkup9rwztKRSX2Lyja_Ts8eUg>
    <xmx:VDloWzypFZXXwpzJIBu9muz2FYjtxIJybsMMzw-daFLFnGzIr_QcUA>
    <xmx:VDloW5M_byPNoheJXgBOG-hITWu65ks0oeWcpNctFu6v_3hQNJUDHw>
    <xmx:VDloW06hxgho_uJBDi4pRwnjX365ARpR3MiGAUzqMXuy838v-mt1XQ>
    <xmx:VDloW6Ot_iaBsV2tx7lg87cxj1oMCL1lMCfaZZ45QU7QgKyMk1_9jg>
    <xmx:VTloWwRxIcrWLEHmKR_SgyYyBMCSv_xEaPGB6veRY7JdBPDRjh5Hbg>
X-ME-Sender: <xms:VDloW9ClOOggIUtiJMhznYEMMzntRRtfadJsIIge3gh_8SfkknvgPA>
Message-Id: <1533557076.2551857.1464840032.5374495A@webmail.messagingengine.com>
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Anton Shestakov <av6@dwimlabs.net>, zsh-workers@zsh.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
X-Mailer: MessagingEngine.com Webmail Interface - ajax-2be8cd1b
In-Reply-To: <20180806190914.246b9514@neuro>
Date: Mon, 06 Aug 2018 12:04:36 +0000
Subject: Re: [PATCH 2/5] _hg: declare appropriate local parameters for ->string
 form
References: <20180806072813.5051-1-av6@dwimlabs.net>
 <20180806072813.5051-3-av6@dwimlabs.net>
 <CGME20180806092113epcas2p1be3488679902085a99d66331745e15d4@epcas2p1.samsung.com>
 <20180806092032.uizmxvlc2oku2ik6@tarpaulin.shahaf.local2>
 <20180806092931eucas1p1c89ebf9f2ee4f5bb40ac2c650cf4a6f2~IQZLFzTOa0396203962eucas1p1k@eucas1p1.samsung.com>
 <20180806190914.246b9514@neuro>

Anton Shestakov wrote on Mon, 06 Aug 2018 19:09 +0800:
> Okay, does this look better? (focusing only on _hg_cmd_resolve for now)

Looks good to me, too.