From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-43246-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 29471 invoked by alias); 6 Aug 2018 12:06:11 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 43246
Received: (qmail 28410 invoked by uid 1010); 6 Aug 2018 12:06:11 -0000
X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from <d.s@daniel.shahaf.name>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(66.111.4.25):SA:0(-2.6/5.0):. 
 Processed in 0.476317 secs); 06 Aug 2018 12:06:11 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,
	SPF_HELO_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1
X-Envelope-From: d.s@daniel.shahaf.name
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	daniel.shahaf.name; h=content-transfer-encoding:content-type
	:date:from:in-reply-to:message-id:mime-version:references
	:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=zw8jWu
	wTeJ1vJWhidkNQg5hQ1xYWR7Ez6N2W8S7qYdk=; b=IB7fLdRhZUEEEHN2TNoeZI
	yLSTuVmWPJcNN3PmC6pwz6NVEgBbNVBK1+Z0Mo5pPLe2Sqo6ttb3ZuXyXgtTG5Rp
	SsEoF8a57cbdD7nIBGrHf5LOCG7i3z1ByGzfPZtAVITNs1qa3rQD0MPA+NGgU0h2
	Vn189Qi8U+VqPuk8K1c+V6ZTkeXa65enoMKr9JdeR5cVubCBLgnp89Dm0eWj35LS
	WqBcJzidSxr6oGTlKO27qbIS8thlu3qz2M/HedTO0iW6Shxdvz606NIvcgCskJLB
	9Ix+/Y1NXVmhK6djXImeKTtuRajvse/JC97JU3WuxOzK+nzB7d4GAx7bqoob65+g
	==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=content-transfer-encoding:content-type
	:date:from:in-reply-to:message-id:mime-version:references
	:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=zw8jWu
	wTeJ1vJWhidkNQg5hQ1xYWR7Ez6N2W8S7qYdk=; b=Yhk56NaTk0wkADUYRjFDiR
	vi9XfYDgTFI3p1rsuBpYpnobZ2rKW8LiaxRet61ZEfQifVssuJLXpwETeF8QDfDB
	JxMq8TYw+owYZ17B9JQX2jezUbETQ/r+OF86Vp9vpq80SyvT8OOPdRkTzF/DdPT3
	vvtJjXBGEyRvSERXeAJvxXh9/uYdEsWb1vVjaw4jMiWOtLq/e2LnGvVySVChb2qV
	imJehXXJqx2Poa1Ja1zh8x4LNAPFfYll74obcpk1npH+Blt+YE48SDkH50FHis6r
	8PbASOnFceg5z2YV2gYtEY84vbMfof2KqZqb/w5xNlb6sI4DEzmNKhzHtkjyyd9w
	==
X-ME-Proxy: <xmx:sDloW20UO3NKw5376TNG3J2dgWoONA4Hcncwcn24VhHy4QgF1dgYzg>
    <xmx:sDloW03Wi3tqCtudVnBev3fz7Uya45_trGDYH4lFc3_OPj3ild5Waw>
    <xmx:sDloWxo-fTELfOWesoDEXBUvK94-fatByHn0JAkXu307qDSARnPx7w>
    <xmx:sDloW93L_FMfwVo1wYiYCw62a_kDVAufCu8s-E7gYfccGle8jS1FCg>
    <xmx:sDloWy15aQBj-JgtTDnLKxgvhlFbuqzuh9zU5xbUnS7uP3DBWb-ryA>
    <xmx:sDloWya9vQNWQ7Ui_o22WrakxWsNasaH6JSo7qGLkRYYZ7ZJaHO9CQ>
X-ME-Sender: <xms:sDloW1T4NmKMa2KWWhpCvgEuS_aQLx4sZGHWTMRbVjeVxEKKfW9uig>
Message-Id: <1533557168.2552060.1464840800.74A5BE28@webmail.messagingengine.com>
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Peter Stephenson <p.stephenson@samsung.com>, zsh-workers@zsh.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
X-Mailer: MessagingEngine.com Webmail Interface - ajax-2be8cd1b
In-Reply-To: <20180806092931eucas1p1c89ebf9f2ee4f5bb40ac2c650cf4a6f2~IQZLFzTOa0396203962eucas1p1k@eucas1p1.samsung.com>
Date: Mon, 06 Aug 2018 12:06:08 +0000
Subject: Re: [PATCH 2/5] _hg: declare appropriate local parameters for ->string
 form
References: <20180806072813.5051-1-av6@dwimlabs.net>
 <20180806072813.5051-3-av6@dwimlabs.net>
 <CGME20180806092113epcas2p1be3488679902085a99d66331745e15d4@epcas2p1.samsung.com>
 <20180806092032.uizmxvlc2oku2ik6@tarpaulin.shahaf.local2>
 <20180806092931eucas1p1c89ebf9f2ee4f5bb40ac2c650cf4a6f2~IQZLFzTOa0396203962eucas1p1k@eucas1p1.samsung.com>

Peter Stephenson wrote on Mon, 06 Aug 2018 10:29 +0100:
> On Mon, 6 Aug 2018 09:20:32 +0000
> Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > To -workers, couldn't we write a wrapper such as the following:
> > 
> >     _added_matches_p() {
> >         local nmatches=$compstate[nmatches]
> >         "$@"
> >         (( nmatches < $compstate[nmatches] ))
> >     }
> > 
> > to reduce the need to manage $ret in every single layer of the
> > callstack?
> 
> Are you suggesting avoiding looking at the return value, but looking at
> what its effect would have been at the point where you would have looked
> it?

Yes.