From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7552 invoked by alias); 20 Aug 2018 13:11:25 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43319 Received: (qmail 6242 invoked by uid 1010); 20 Aug 2018 13:11:25 -0000 X-Qmail-Scanner-Diagnostics: from wout2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(64.147.123.25):SA:0(-2.6/5.0):. Processed in 1.422919 secs); 20 Aug 2018 13:11:25 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=mfiGes 4wmOBYADqiweCv4BrMrtd7Dh2DIyEpsNekeAg=; b=U+jQlJpgu6n9ivlNv3uKoD Vfz/VLc400BBL9sf8y5WMtTU6q00Fe3dUF6BNNN5Lcw+FHY7KajDZRe1PF745xRs c6RDSe15BmZc91VGMHaAqo6EG+kchPUDsVCP6EgcuvXQzYv3aHHnNokm6YcxrASK ggQfbnaElvIzUHPFrmA1zDb99x1SY8hwWh+gDftMyK5aFudtYQdq1uSZPmskebY9 DASI/6r5dq9UONqXALgAiC96istrpnuiIbkLEPZU9a/0mel3DkI+HSxUuC874ia0 hvDn7fAROkjBdzv7HAEzEeDyeMZZLIHwXWZInz4sDdh6jZ9jC5psViLmS3WeYgFw == DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=mfiGes 4wmOBYADqiweCv4BrMrtd7Dh2DIyEpsNekeAg=; b=NKLGijNGfxA3lrKnyzv2Qe 2LfkdsWNf8qsfCtXvmUL8/W5Z6l9IVRENL381GwrUd+TzggZnK0ru4ftg8rHA4aM kJNVP0TFVG+9ia8w9hoaUfuu92/45VFWLsgWojhF3Dfop5ZonR5DHEoocVJ/r+oe T6osUXlfsNvtCzM1g6kXLAZ04WiJ5ZIeRAr/+CS4GqH37fNY0sPOSwNbNYUXCiVY Qv43Cr5yEMLYkEGhglmamy0zjimy1hYyh+jyi7alwnSSvPCyxtgEixYoZZatNCzR bFIQJGW2CsnPmpqpVAQvJ+G51ODrEdQ7dj5ZOn4Nc57HbuLZZ/x6WkdfSZoD4z4w == X-ME-Proxy: X-ME-Sender: Message-Id: <1534770135.103410.1479921056.7CBC27FA@webmail.messagingengine.com> From: Daniel Shahaf To: Frank Terbeck Cc: zsh-workers@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-7b72137a Date: Mon, 20 Aug 2018 13:02:15 +0000 Subject: Re: [PATCH 2/2] vcs_info git: For the branch name, try to find a symbolic name before falling back to a raw commit hex. References: <20180818155719.23574-1-danielsh@tarpaulin.shahaf.local2> <20180818155719.23574-2-danielsh@tarpaulin.shahaf.local2> <87y3d3mmpz.fsf@ft.bewatermyfriend.org> <1534681967.2423927.1478973456.762A6FF2@webmail.messagingengine.com> <87r2itmfc3.fsf@ft.bewatermyfriend.org> In-Reply-To: <87r2itmfc3.fsf@ft.bewatermyfriend.org> Frank Terbeck wrote on Mon, 20 Aug 2018 13:45 +0200: > Daniel Shahaf wrote: > > 1. Adding knobs induces a maintenance cost going forward. Is that cost > > justified in this case? We can always add the knob later if there's > > demand for it, but it's harder to take away behaviour once it has > > been released. > > > > 2. At what point in the if-chain do we raise the white flag^W^W^W^W > > check the "early exit?" style? > > > > I suppose we could overload the `use-simple` style for this purpose (the > > git backend doesn't currently use that style). The `get-revision` style > > is also relevant. > > Yeah. The git backend is pretty complex as it is. Maybe it's not worth > it, to make this configurable. I don't know. Let's leave the style out until/unless someone asks for it. It'd be trivial to add later if we want it.