From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Maximilian Bosch <maximilian@mbosch.me>, zsh-workers@zsh.org
Subject: Re: PATCH: search XDG_DATA_DIRS in _setxkbmap completion
Date: Wed, 19 Sep 2018 21:30:37 +0000 [thread overview]
Message-ID: <1537392637.2062287.1514014736.039478F3@webmail.messagingengine.com> (raw)
In-Reply-To: <20180919203617.u7qqocenjurq73l3@hauptschuhle>
Maximilian Bosch wrote on Wed, 19 Sep 2018 22:36 +0200:
> > Depends on how empty elements should be handled. In some contexts an
> > empty element means "look in the current working directory", and I
> > wasn't sure how the XDG spec defines this case. It's not a blocker but
> > it would be nice to get this right while we're here.
>
> I had a look at the XDG specification[1], unfortunately it doesn't
> mention the case of empty search path entries. Do you know what's the
> preferred default behavior?
>
No. I just committed the patch as-is: it's an improvement, and if we
find that empty elements need special handling we can add it in a
subsequent patch.
> Again, thanks a lot for your feedback, I've implemented your
> suggestions.
You're welcome, and thanks for the iterations.
Cheers,
Daniel
next prev parent reply other threads:[~2018-09-19 21:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 12:49 Maximilian Bosch
2018-09-18 16:10 ` Daniel Shahaf
2018-09-18 19:05 ` Maximilian Bosch
2018-09-18 19:32 ` Daniel Shahaf
2018-09-19 20:36 ` Maximilian Bosch
2018-09-19 21:30 ` Daniel Shahaf [this message]
2018-09-19 4:53 TS
2018-09-19 14:29 ` Daniel Shahaf
2018-09-19 19:53 ` TS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537392637.2062287.1514014736.039478F3@webmail.messagingengine.com \
--to=d.s@daniel.shahaf.name \
--cc=maximilian@mbosch.me \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).