From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: zsh-workers-return-43553-ml=inbox.vuxu.org@zsh.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id d83c45e7 for ; Tue, 25 Sep 2018 20:37:02 +0000 (UTC) Received: (qmail 28331 invoked by alias); 25 Sep 2018 20:36:41 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43553 Received: (qmail 21128 invoked by uid 1010); 25 Sep 2018 20:36:41 -0000 X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.25):SA:0(-2.6/5.0):. Processed in 7.451974 secs); 25 Sep 2018 20:36:41 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=wCH1Jp Bct2y8yWGkpbDdpTy+LNRFfYKeZ8uIDW7G418=; b=GJqrGKZ/kXwaQQ5lKGqpfE uOFeLlEvzA4PIYhylMgyXh6Fj8K46RG+SbsliH+xlTkuz0pzH71R7G/+OcpcQidh bHJW1g3KqNGr1o5EQnJi63e+36p88InXvzxxP+fCI97W6060CU/jwk14tPehdVLD xqDtJK9WANK4UrGX8IeucVAwORcKHATnaQBlFhk+gOyp+HlDEtNSkByIcaY73GB8 /0wRrB+xtDqqmTMMyhI2tpm7A4P0+y6xZi0HCw1uOvywWORVyWT/roIkIkv/PDq+ bWfjgabTngd+rxRClpq1n5EhW5aJSUGk25qFPLIi81aqRLaA2ZXnyMdqFSDom/Uw == DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=wCH1Jp Bct2y8yWGkpbDdpTy+LNRFfYKeZ8uIDW7G418=; b=ehKqy8Tp5f2ypkINKN1TIq 7NzmX7zZwOxVsYeVor2u5H+OlB0FSo40OZAZQ4YmFkPCb7jH4WSm201mKYs7KmTr uOmJu+NRTz3Om9q3/iLDjkkQJ60L7qAmVGVy1kIHS2VSaukHjDs0ngqKoqTFS7o5 iX2pHOlYveFhsGvFKSTcYFY990/k50Zky96OIxx8HJ7ISIOU5Wd3mC7emjU5ZBbp kgSXsd3ZBOFSIGl8iZ/ZNwV+q+Ul0QsRhvbGMCK+v/zOf3fVOv0B8nMWMhnfT3Tk 8WivL8KiGzT+FPFktbDOLliehx44TwvyLq1xJb3tFooFo/hJdVVl1j9Ro6wwCArg == X-ME-Proxy: X-ME-Sender: Message-Id: <1537907787.166425.1520521784.2C5972A6@webmail.messagingengine.com> From: Daniel Shahaf To: Oliver Freyermuth Cc: zsh-workers@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-2e36a0dc Date: Tue, 25 Sep 2018 20:36:27 +0000 In-Reply-To: <75619dc0-7b02-45bd-7cd9-a5078d6829a5@googlemail.com> References: <057ea9a2-d934-59e6-3109-e5093f0f9878@googlemail.com> <20180925192153.uwitfgrd2yydxtah@tarpaulin.shahaf.local2> <75619dc0-7b02-45bd-7cd9-a5078d6829a5@googlemail.com> Subject: Re: zathura conpletion for zsh broken Oliver Freyermuth wrote on Tue, 25 Sep 2018 22:02 +0200: > Am 25.09.18 um 21:21 schrieb Daniel Shahaf: > > Oliver Freyermuth wrote on Tue, Sep 25, 2018 at 17:14:04 +0200: > >> +++ b/Completion/X/Command/_zathura > >> @@ -25,7 +25,7 @@ _zathura_files(){ > >> - supported_filetypes+=3D"${${pf%.so}#${plugins_dir}/lib}" > >> + supported_filetypes+=3D"${${pf%.so}#${plugins_dir}/}" > >=20 > > Isn't this equivalent to =C2=ABsupported_filetypes+=3D${pf:t:r}=C2=BB? >=20 > Indeed, it is, and that would be much easier.=20 Pushed. I changed the log message to avoid mentioning implementation terms (the variable's name) in ChangeLog, which is user-facing. > > The 'break' on line 12 looks odd. Does zathura really ignore > > /usr/lib/zathura/foo.so if /usr/local/lib/zathura/bar.so exists and > > /usr/local/lib/zathura/foo.so does not? >=20 > You are correct in spotting this, if I read the zathura code correctly > (not a girara expert...), it "does the right thing" and searches the > full list of paths. >=20 > I'll try to cook up a patch fixing both those issues. Might take a > while though, since I'm just starting with this (basically I started > to investigate after "zathura " stopped doing anything after a > zsh upgrade, makin=C9=A1 usage rather cumbersome). Thanks for the patch and looking into the additional issue. Cheers, Daniel P.S. Our of curiosity, what's that U+0261 LATIN SMALL LETTER SCRIPT G doing= there? > Thanks for the pointers! > Oliver