From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: zsh-workers-return-43627-ml=inbox.vuxu.org@zsh.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 98301e86 for ; Mon, 8 Oct 2018 13:53:01 +0000 (UTC) Received: (qmail 25222 invoked by alias); 8 Oct 2018 13:52:50 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43627 Received: (qmail 4977 invoked by uid 1010); 8 Oct 2018 13:52:50 -0000 X-Qmail-Scanner-Diagnostics: from out3-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.27):SA:0(-2.6/5.0):. Processed in 1.259948 secs); 08 Oct 2018 13:52:50 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=message-id:from:to:mime-version :content-transfer-encoding:content-type:references:date:subject :in-reply-to; s=fm1; bh=o43rfZBn8KeuMuXOfMArfzWnHqKLlkqmf+G3vqLJ RLk=; b=gsQj2F1hyweZve7Hmkh/hv4iui+4u8yXdECIHHjixql1Ajz0/mDvunY+ deyiTVmDEeieTXi1r1KYhMz1tFl67ZcEaVMyHl6sONyw8Sv5xOuXKKazbwkesQzI vZb+MOm8sl9nJkWiJxNnrkkVgJt535VLdz3QHVPFAcdZdkoS4MHvcrGy4JdK7mIU Iu/MqLv65CKUAgqtPH+mIyMDqdUTkQ9rbim28MeN6HIYaRXR5Tvwux94WudIt3aI hrawa9zMSZiksPGsU6dDEH/XXFztI4Rmb7TN5ulPf39B54t7kRiAMuixb3W1/Phv CYdMX/GW7Z1vCTi3dHVu5QGMLAfqhw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=o43rfZBn8KeuMuXOfMArfzWnHqKLlkqmf+G3vqLJR Lk=; b=rcNqCn3CpfEaBoV9s9r9KChrfMv7SC4+K0/FgAZOIDpQ6huUaY4avTIM6 084vPGzYrsQjW/obfqZeJkFzLLEBcjNama8JL0Vw8XndNfeQU5MPNaW3Wur4YE6Y M+75s7UlfIbtDB2v3BnYrx7HE4f3kHKvpwnPreI2l3Fbhym7+XBEve9wU4XWngmY 5mdVfn9oTjFMRJf8aeemD2WyuNLaScG+Y9o9tZJbemejpBALedziFr4VxK9Fo0Qa xFxrCGXCLiUkdL1GhJrgAqta941Ftveb1NiYIg+Qc37O1DACLihIz1EdGDo2yW0c BqX2MEQUaB36hGbgUmJp9W+2hnMmw== X-ME-Sender: X-ME-Proxy: Message-Id: <1539006766.1356412.1534584328.7E5D4774@webmail.messagingengine.com> From: Daniel Shahaf To: "a-wing" <1@233.email>, zsh-workers@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-929b9749 References: <20181008032424.4260-1-1@233.email> <20181008032424.4260-2-1@233.email> Date: Mon, 08 Oct 2018 13:52:46 +0000 Subject: Re: [PATCH 2/2] Fix Completion iptables 194: ;& => ;; In-Reply-To: <20181008032424.4260-2-1@233.email> a-wing wrote on Mon, 08 Oct 2018 11:24 +0800: > --- > Completion/Linux/Command/_iptables | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Completion/Linux/Command/_iptables b/Completion/Linux/ > Command/_iptables > index ae8d66ea4..2d9697418 100644 > --- a/Completion/Linux/Command/_iptables > +++ b/Completion/Linux/Command/_iptables > @@ -191,7 +191,7 @@ case "$state" in > _wanted targets expl 'builtin target' compadd \ > ACCEPT DROP QUEUE RETURN DNAT DSCP ECN LOG MARK MASQUERADE MIRRO= R \ > REDIRECT REJECT SNAT TCPMSS TOS ULOG && ret=3D0 > - ;& > + ;; I'm sorry but this patch is wrong. iptables(8) explicitly states: [[[ TARGETS =E2=80=A6 the value of = the target, which can be the name of a user-defined chain, one of the targets described in iptables-extensions(8), or one of the special values ACCEPT, DROP or RETURN. ]]] For future reference, log messages should describe the functional change and its purpose, not the syntactic change. That is, it should say something _beyond_ what can be understood by parsing the unidiff. Thanks for the patch, Daniel