zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: "a-wing" <1@233.email>, zsh-workers@zsh.org
Subject: Re: [PATCH 2/2] Fix Completion iptables 194: ;& => ;;
Date: Mon, 08 Oct 2018 13:55:04 +0000	[thread overview]
Message-ID: <1539006904.1356754.1534588544.3D01DBC1@webmail.messagingengine.com> (raw)
In-Reply-To: <1539006766.1356412.1534584328.7E5D4774@webmail.messagingengine.com>

Daniel Shahaf wrote on Mon, 08 Oct 2018 13:52 +0000:
> For future reference, log messages should describe the functional change and
> its purpose, not the syntactic change.  That is, it should say something
> _beyond_ what can be understood by parsing the unidiff.

For example, "Don't complete user-defined chains when completing targets".

  reply	other threads:[~2018-10-08 13:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08  3:24 [PATCH 1/2] Fix Completion iptables -t raw security a-wing
2018-10-08  3:24 ` [PATCH 2/2] Fix Completion iptables 194: ;& => ;; a-wing
2018-10-08 13:52   ` Daniel Shahaf
2018-10-08 13:55     ` Daniel Shahaf [this message]
2018-10-08 13:50 ` [PATCH 1/2] Fix Completion iptables -t raw security Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1539006904.1356754.1534588544.3D01DBC1@webmail.messagingengine.com \
    --to=d.s@daniel.shahaf.name \
    --cc=1@233.email \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).