From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: zsh-workers-return-43686-ml=inbox.vuxu.org@zsh.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 5fe66fb7 for ; Fri, 12 Oct 2018 13:43:32 +0000 (UTC) Received: (qmail 29750 invoked by alias); 12 Oct 2018 13:43:21 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43686 Received: (qmail 2470 invoked by uid 1010); 12 Oct 2018 13:43:21 -0000 X-Qmail-Scanner-Diagnostics: from out3-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.27):SA:0(-2.6/5.0):. Processed in 0.775474 secs); 12 Oct 2018 13:43:21 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=message-id:from:to:mime-version :content-transfer-encoding:content-type:references:subject :in-reply-to:date; s=fm1; bh=mjhKLwRhJRlOZLHLLk5iDhUNVuvsSagEu5X Lm1lsmxs=; b=BdpzXvY6eljlXGG+Y6i3YHvn/bQOHU8YOANl4uZiygTj8JTP0lC VnhyEDQo58rYBkZff6uvT4i067N+y02nwzXvrI3E6QbcaQrN+wj+GGan6K+U+3y1 5dC7lyaHmT+J//r7sHuVUCr/Jh5Wg1GajtfLRXxXAV0CkDAov6OzzfnYr1ifzYJj XHfnEcHKKcfwTHPfeAcMV83KwsNRkQtoN2y9uOi+R19WVSrDvgF2W9S5UJSTV8bq 1pONOhlszlb1FzbmziRC4fAeYY9f0aqhP6tlKiAZ+MNiD79usqFxf/JmNG9q/rDG m5m/strvPneLDp/NOyigtD/axP9qizOqEfA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=mjhKLwRhJRlOZLHLLk5iDhUNVuvsSagEu5XLm1lsm xs=; b=qzsIxMxJvp4wQ/5XqQ2Dwhr8uQcQ3kbnos7yzP9KuCuM8UB2MnR7mPsBq rjeqmErjJpkbjs1ugLKXZGTkaVpADwQ4ToqlWbH+qZDQZ2JQkJZ7Ca4xocrW2RSz 5LyELX7CrMKddV4n6Kaj8oVJnLVom3C43gvEpIOECY2UE1wW+DRq/pVrdV7rARG6 Vw1sZ8DiSvOEvgpC8IYydWCDmQEpQ7fKEltlfmYZaa6oRvmwZmc1hMpIfQQixeya Zh7ba5B8CHjpGC7PAwsthZ8j5qkRqee1zKb3txJxIZfj/nc1P08YqoCtzlN0lAXt rBr5iH/9lxuLILv3Utfu0aLM9AiQw== X-ME-Sender: X-ME-Proxy: Message-Id: <1539351797.1194808.1539818208.4B58E8C9@webmail.messagingengine.com> From: Daniel Shahaf To: zsh-workers@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-6804a824 References: <20181012134037.16689-1-danielsh@tarpaulin.shahaf.local2> <20181012134037.16689-2-danielsh@tarpaulin.shahaf.local2> Subject: Re: [PATCH 2/2] add-zle-hook-widget: Add a missing arithmetic evaluation to the new index's computation. In-Reply-To: <20181012134037.16689-2-danielsh@tarpaulin.shahaf.local2> Date: Fri, 12 Oct 2018 13:43:17 +0000 Daniel Shahaf wrote on Fri, 12 Oct 2018 13:40 +0000: > +++ b/Functions/Misc/add-zle-hook-widget > @@ -152,7 +152,7 @@ function add-zle-hook-widget { > - i=${${(On@)${(@M)extant_hooks[@]#<->:}%:}[i]:-0}+1 > + (( i = ${${(On@)${(@M)extant_hooks[@]#<->:}%:}[i]:-0} + 1 )) Never mind, Matthew just pointed out to me that the code was correct as is (assigning to integers implicitly does evaluation). I'll skip this patch.