zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] ztrsub() execution time / 2
Date: Wed, 17 Oct 2018 19:34:22 +0000	[thread overview]
Message-ID: <1539804862.2700189.1545590272.19CD9FF7@webmail.messagingengine.com> (raw)
In-Reply-To: <CAKc7PVDWKTwaV-4iMOA0NjBVRMfhu211AYUw5Z9VPS4AmX1x7Q@mail.gmail.com>

Sebastian Gniazdowski wrote on Wed, 17 Oct 2018 21:02 +0200:
> On Wed, 17 Oct 2018 at 16:25, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > As far as I can tell, this patch is the sort of transformation that an
> > optimizing compiler should do by itself.  In fact, I'm having a hard time
> > seeing how the sequence of "BRANCH IF EQUAL" / "BRANCH IF NOT EQUAL" /
> > "INCREMENT" assembly instructions would be altered by the patch.
> >
> > If your profiling was performed on zsh compiled with -O3, I would suggest that
> > you file a bug against your compiler's optimizer.
> 
> Why not "do it right, then do it yourself"? Why ignore -O0 zsh users?
> Should I subscribe to compilers mailing lists and investigate this
> well defined 1-line change, i.e. possible to grasp by logic?

I have a hard time charitably interpreting what you just wrote.  It
doesn't come across as constructive.

I think the patch should not be applied because it makes the code harder
to read and to maintain.

Daniel

      reply	other threads:[~2018-10-17 19:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-17  4:29 Sebastian Gniazdowski
2018-10-17 14:25 ` Daniel Shahaf
2018-10-17 19:02   ` Sebastian Gniazdowski
2018-10-17 19:34     ` Daniel Shahaf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1539804862.2700189.1545590272.19CD9FF7@webmail.messagingengine.com \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).