From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 39a98276 for ; Thu, 15 Nov 2018 12:53:38 +0000 (UTC) Received: (qmail 3359 invoked by alias); 15 Nov 2018 12:53:27 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43828 Received: (qmail 28146 invoked by uid 1010); 15 Nov 2018 12:53:27 -0000 X-Qmail-Scanner-Diagnostics: from mailout1.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25112. spamassassin: 3.4.2. Clear:RC:0(210.118.77.11):SA:0(-7.6/5.0):. Processed in 3.24705 secs); 15 Nov 2018 12:53:27 -0000 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20181115124439euoutp012d63751b2fb21fb47b3cfcd3fb0a9c90~nTNYWkA9b1437314373euoutp01F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1542285879; bh=88Tmh31WBmqTXFGaNiUugRWCCqUgiRq/09CwGgKPWcU=; h=Subject:From:To:Date:In-Reply-To:References:From; b=V/T6iO7xEw9qE9s1/q37IhQioU1yTlY9ROWWlqXjVIyOiSGwoUA8YFo7cvbSf0ZjY V+8WagZpSV59m8RDd7aW/yY44uofJD6rMvJGYVCmDKs2I6KqUXLcf6P5yu0NXNPc5h HkuIZaI4066ANQROYcbbKxVwzVZ893LCkrxDIa14= X-AuditID: cbfec7f5-367ff700000012c6-22-5bed6a37f2ea Message-ID: <1542285877.4637.3.camel@samsung.com> Subject: Re: Terminal theme tool =?UTF-8?Q?=E2=80=93?= a workaround for lack of 24-bit color in Zsh? From: Peter Stephenson To: Date: Thu, 15 Nov 2018 12:44:37 +0000 In-Reply-To: X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPIsWRmVeSWpSXmKPExsWy7djP87rmWW+jDS5/YLY42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGW+X/GQsOMhR0bX6A0sD42O2LkZODgkBE4n7rz4wdTFycQgJ rGCUOPKknQ3C6WOSWPf+AVSml0liffssZpiWln8vmSESyxkl9mw8wg5XtbJlMVT/GUaJ5dtW skA4Fxgl5h3dC7aSV8BQ4vrk14xdjBwcwgJpEltvRICE2YDCUzfNZgSxRQQkJa41nwazWQRU JY7u6wZr5RRwldhy4xQLxBkaEhtuHmOCGCkocXLmE7A4s4C8RPPW2WDnSQg8ZpN48GshVIOL xK7+OVA/CEu8Or6FHcKWkTg9uYcFoqGdUWLNpNfsEE4Po8Smo3cYIaqsJfpuXwS7mllAU2L9 Ln2IsKNE06l9LCBhCQE+iRtvBSGO4JOYtG06M0SYV6KjTQiiWk1iR9NWRoiwjMTTNQoTGJVm IflgFpIPZiGsWsDIvIpRPLW0ODc9tdg4L7Vcrzgxt7g0L10vOT93EyMwGZz+d/zrDsZ9f5IO MQpwMCrx8N7weBMtxJpYVlyZe4hRgoNZSYR3UsTbaCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8 1QwPooUE0hNLUrNTUwtSi2CyTBycUg2MErFTNfTnvlG+GrahvVM7LmHC4kVT/9nOqjJlv8Hx sH1N9RIL8YDz3me8Vv3bNy3vsO9Pb/M/Vm+Kj3rkf5qreyRAr8djrf7i3937GUVndlv0BCWt Yp7KFyq6cHKNv5Np+LLDcWbzjHYbVFvxv5K1n7D1iqzGresPpvVfXnlJZvqCIh9hiYoJSizF GYmGWsxFxYkASCwgrAIDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkkeLIzCtJLcpLzFFi42I5/e/4XV2zrLfRBj+aeS0ONj9kcmD0WHXw A1MAY5SeTVF+aUmqQkZ+cYmtUrShhZGeoaWFnpGJpZ6hsXmslZGpkr6dTUpqTmZZapG+XYJe xtslPxkLDnJUdK3+wNLA+Jiti5GTQ0LARKLl30vmLkYuDiGBpYwSy6e2MEIkZCQ+XfnIDmEL S/y51gXWICTQzSTxZ4cERMMZRon10+6yQjgXGCXOTtsNVsUrYChxffJroEkcHMICaRJbb0SA hNmAwlM3zQZbICIgKXGt+TSYzSKgKnF0XzdYK6eAq8SWG6dYIGb2Mkn86lsClmAW0JRo3f4b 6iINiQ03jzFB7BKUODnzCQtEjbxE89bZzBMYhWYhaZmFpGwWkrIFjMyrGEVSS4tz03OLDfWK E3OLS/PS9ZLzczcxAoN/27Gfm3cwXtoYfIhRgINRiYf3hNWbaCHWxLLiytxDjBIczEoivJMi 3kYL8aYkVlalFuXHF5XmpBYfYjQF+mgis5Rocj4wMvNK4g1NDc0tLA3Njc2NzSyUxHnPG1RG CQmkJ5akZqemFqQWwfQxcXBKNTAGVd+6yqAuzsh8w34v/5Q/l9pn1B2vbd4iuC7eZQlPxpdg tf1bH/6I3D3FpJZX55gre73HnxZdA66dopO8v6l1rsoMFXijt168l/n8W8uV+t/rTzDtiGvw bJVyu3l/g/c2/vgsKfnFHDdsg1c5/jjDGvbI1ITxlKmu944ygzWlWyJ5RRcseK/EUpyRaKjF XFScCADbQN4XlAIAAA== X-CMS-MailID: 20181115124438eucas1p2540f2aff74bc7a85f88052c55565143d X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181115123621epcas4p154967be4f87a5221c5012b4caa1cd732 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181115123621epcas4p154967be4f87a5221c5012b4caa1cd732 References: <58111-1540942908.680582@SXAw.BXd_.-x5N> On Thu, 2018-11-15 at 20:50 +0900, Jun T wrote: > In nearcolor.c, function RGBtoLAB(), floating point data are saved in > float (not double) variables; for example: >  > >  > > +     float R = (float)red / 255.0; > (snip) > >  > > +     R = 100.0 * (R > 0.04045 ? powf((R + 0.055) / 1.055, 2.4) : R / 12.92); > Is this to improve performance? > If so, it would be better to explicitly use float literals, such as 255.0f. > Otherwise, since 255.0 is double, all the calculations are done in double > (after promoting all values to double), and the final result is truncated > back to float. >  > I believe there is virtually no performance difference (on most CPUs). The majority of standardish Unixy systems I know about are designed to assume most floating point calculations are going to be done as double --- I see Linux supplies float and long double versions of library functions as a supplement.  But I doubt Oliver was thinking that much about optimisation here --- terminal IO is slow enough I can't see how it could be a big deal. pws