From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 121d3073 for ; Tue, 27 Nov 2018 15:09:17 +0000 (UTC) Received: (qmail 19890 invoked by alias); 27 Nov 2018 15:09:02 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43850 Received: (qmail 22485 invoked by uid 1010); 27 Nov 2018 15:09:02 -0000 X-Qmail-Scanner-Diagnostics: from mailout1.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25112. spamassassin: 3.4.2. Clear:RC:0(210.118.77.11):SA:0(-8.5/5.0):. Processed in 2.45679 secs); 27 Nov 2018 15:09:02 -0000 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20181127150854euoutp016fc5eb07233838d8b860a34bb84395b2~rA6wOnp-q0534405344euoutp01H DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1543331334; bh=CDo6brSSSOgpE9UCcHy9OEnpzES+ucVrIoK7dVf78og=; h=Subject:From:To:Date:In-Reply-To:References:From; b=O+aTIzrby8p3s/hJSsPSBHw8QabLDhUbWM6fwhAKv0MYL4Ayt3syc2BL0yfvIbkoJ wIxAmB4AwPR8ldLoFDWgobR2+HNmFOPSieM/1MPHz2GRs+WNNJ5JVvJMA4AM64bG0a kiVo3otCsbNeqf1vt9/yI+R5t44DjCs6UhIxvZ3U= X-AuditID: cbfec7f4-835ff700000010c6-72-5bfd5e067cf2 Message-ID: <1543331332.4259.24.camel@samsung.com> Subject: Re: [BUG] Glob handling is brittle From: Peter Stephenson To: Date: Tue, 27 Nov 2018 15:08:52 +0000 In-Reply-To: <942D7657-1371-4A04-B2E7-1CBFE9DC0966@kba.biglobe.ne.jp> X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsWy7djP87pscX+jDaYc4rI42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGfeXXmcqaOaqaH68ka2BsZ+ji5GTQ0LARGLu/olsXYxcHEIC KxglZizqZQRJCAn0MUnsXxkEYfcySdzeZAvTsLFhKTNEw3JGiSnPW1ghHKCiawvuQnWfAcrM FYRIXGCUODltJQtIglfASKJ9znQwW1hAW2L6391gDWwChhJTN80Gs0UEJCWuNZ8Gs1kEVCU+ Tb4PZHNwcAq4SszZGgRxhYbEhpvHmCBGCkqcnPkEbCSzgLxE89bZYNdJCDxmk+jsWcMM0eAi cfrua3YIW1ji1fEtULaMxOnJPSwQDe2MEmsmgRSBOD2MEpuO3mGEqLKW6Lt9EewKZgFNifW7 9CHCjhJ/W8+ygIQlBPgkbrwVhDiCT2LStunMEGFeiY42IYhqNYkdTVsZIcIyEk/XKExgVJqF 5INZSD6YhbBqASPzKkbx1NLi3PTUYqO81HK94sTc4tK8dL3k/NxNjMA0cPrf8S87GHf9STrE KMDBqMTDu+H772gh1sSy4srcQ4wSHMxKIryW/n+jhXhTEiurUovy44tKc1KLDzFKc7AoifNW MzyIFhJITyxJzU5NLUgtgskycXBKNTCqeztOWpYR5rZo2fONLo4p9x9c9ro0d048v9Di1dO0 fwW8v2BUrrki3X7lmnn5P1+tal94P2rxPsF768+sq566Z2rW6XsXItfef/la0bex5cXh/Yre Bj/uZEU4fI3r1uuYLqIu8+6x5JFz0QK8B8OT3JK+J0/YWMy9ar9Mlnz8VuPLBUX3Njr6K7EU ZyQaajEXFScCACm8IXz/AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkkeLIzCtJLcpLzFFi42I5/e/4XV3WuL/RBsuXSVocbH7I5MDoserg B6YAxig9m6L80pJUhYz84hJbpWhDCyM9Q0sLPSMTSz1DY/NYKyNTJX07m5TUnMyy1CJ9uwS9 jPtLrzMVNHNVND/eyNbA2M/RxcjJISFgIrGxYSlzFyMXh5DAUkaJdStfskEkZCQ+XfnIDmEL S/y51sUGUdTNJPFn/TOwIiGBM4wSn3qCIRIXGCUObr3OCJLgFTCSaJ8znQXEFhbQlpj+dzdY nE3AUGLqptlgtoiApMS15tNgNouAqsSnyfeBbA4OTgFXiTlbgyBmAs1fsWoSK0gNs4CmROv2 31AXaUhsuHmMCWKXoMTJmU9YIGrkJZq3zmaewCg0C0nLLCRls5CULWBkXsUoklpanJueW2yo V5yYW1yal66XnJ+7iREY/NuO/dy8g/HSxuBDjAIcjEo8vBu+/44WYk0sK67MPcQowcGsJMJr 6f83Wog3JbGyKrUoP76oNCe1+BCjKdBDE5mlRJPzgZGZVxJvaGpobmFpaG5sbmxmoSTOe96g MkpIID2xJDU7NbUgtQimj4mDU6qBccFd0TDbZ8ZVk5oPby5f3dqiabaoU/Pr3vZtC3PD+RLL ZG+Ee4lobzM8cvup/5tQ7Vk9T94k39k1K/W0z5feX9PLnM4uau5tylvacZz1pKpGWp+/xMpv /j6T1XrrPJ5sYMtYu/bZ8rvvp+vXxfFfPB63YgL710CjF7+kBKbwGt8u3tP8q6mLRYmlOCPR UIu5qDgRADkEGyqUAgAA X-CMS-MailID: 20181127150853eucas1p1a8cdeb06d2bf18ccebcc8ad784c4ed52 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181127125232epcas2p2e18a287839670075febc0d5ee7a7568c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181127125232epcas2p2e18a287839670075febc0d5ee7a7568c References: <4a07ef77-de18-8966-5f3e-bd544aaaae3f@inlv.org> <942D7657-1371-4A04-B2E7-1CBFE9DC0966@kba.biglobe.ne.jp> On Tue, 2018-11-27 at 21:14 +0900, Jun T wrote: > > 2018/11/26 14:38, Martijn Dekker wrote: > > The script below reliably makes zsh hang. > (snip) > >  > > case '\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\' in > > ( *\\*\\*\\*\\*\\*\\*\\*\\*\\*\\*\\*\\*\\*\\*\\*\\*\\*\\*\\*\\*\\*\\\ > > *\\*\\*\\*\\*\\*\\*\\*\\*\\*\\* ) > >  echo ok ;; > > esac > zsh is not hanging; it is just very slow. Yes, you can see that by gradually increasing the length of the pattern.  Depending on the machine, it starts to get really slow after about half a dozen or so \\* groups. > I don't know whether this can be 'fixed' easily. There's something a bit similar that does improve the case of excluded matches, ~ and ^ --- where you hit pathological cases quite quickly, and which aren't so commonly used in patterns.  That's not nice.  It's almost certainly not a good idea to do it that way here, as * is very widely used indeed.  I can't offhand think of a good way of fixing up pathological cases without having a much more noticeable effect on more typical cases.  But I don't think offhand thinking is what's required here. Really, this is at the point where you need an algorithm expert rather than a bunch of hackers. pws