From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh Hackers' List <zsh-workers@zsh.org>
Subject: Re: PATCH: glob flags at start of word
Date: Tue, 4 Dec 2018 17:03:42 +0000 [thread overview]
Message-ID: <1543943022.3963.23.camel@samsung.com> (raw)
In-Reply-To: <1543942389.3963.21.camel@samsung.com>
On Tue, 2018-12-04 at 16:53 +0000, Peter Stephenson wrote:
> ls (#<TAB>
>
> doesn't complete as globbing flags are treated as a special case of glob
> qualifiers, which can't be completed here.
>
> Fairly minor but I can't see any good reason not to fix it.
This might be safer...
pws
diff --git a/Completion/Unix/Type/_files b/Completion/Unix/Type/_files
index d44ac31..e3212c9 100644
--- a/Completion/Unix/Type/_files
+++ b/Completion/Unix/Type/_files
@@ -17,7 +17,7 @@ if _have_glob_qual $PREFIX; then
_globquals && ret=0
fi
return ret
-elif [[ $_comp_caller_options[extendedglob] == on ]] && compset -P '\(\#'; then
+elif [[ $_comp_caller_options[extendedglob] == on && $PREFIX = \(\#[^\)]# ]] && compset -P '\(\#'; then
# Globbing flags can start at beginning of word, even though
# glob qualifiers can't.
_globflags && return
prev parent reply other threads:[~2018-12-04 17:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181204165310eucas1p15a1a87a45a4de6508fa8457a64e5d9cf@eucas1p1.samsung.com>
2018-12-04 16:53 ` Peter Stephenson
[not found] ` <CGME20181204170343eucas1p211f78886fae04264445654588dc2c4b7@eucas1p2.samsung.com>
2018-12-04 17:03 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543943022.3963.23.camel@samsung.com \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).