From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1075 invoked by alias); 9 May 2011 10:24:03 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29193 Received: (qmail 5208 invoked from network); 9 May 2011 10:24:01 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS autolearn=ham version=3.3.1 Received-SPF: none (ns1.primenet.com.au: domain at csr.com does not designate permitted sender hosts) X-Authentication-Warning: pwslap01u.europe.root.pri: pws owned process doing -bs To: Zsh hackers list Subject: PATCH: bad variable declarations X-Mailer: MH-E 8.2; nmh 1.3; GNU Emacs 23.2.1 Date: Mon, 9 May 2011 11:23:45 +0100 Message-ID: <15447.1304936625@csr.com> From: Peter Stephenson MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.103.11.49] X-Scanned-By: MailControl A_10_80_00 (www.mailcontrol.com) on 10.68.0.115 One sign the shell isn't getting compiled widely enough. Index: Src/text.c =================================================================== RCS file: /cvsroot/zsh/zsh/Src/text.c,v retrieving revision 1.27 diff -p -u -r1.27 text.c --- Src/text.c 6 Jan 2011 20:28:50 -0000 1.27 +++ Src/text.c 9 May 2011 10:22:59 -0000 @@ -893,13 +893,13 @@ getredirs(LinkList redirs) taddstr(f->here_terminator); taddpending(f->name, f->munged_here_terminator); } else { + int fnamelen, sav; taddstr(fstr[REDIR_HERESTR]); /* * Just a quick and dirty representation. * Remove a terminating newline, if any. */ - int fnamelen = strlen(f->name); - int sav; + fnamelen = strlen(f->name); if (fnamelen > 0 && f->name[fnamelen-1] == '\n') { sav = 1; f->name[fnamelen-1] = '\0'; -- Peter Stephenson Software Engineer Tel: +44 (0)1223 692070 Cambridge Silicon Radio Limited Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom