From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id e9779319 for ; Sat, 29 Dec 2018 11:08:54 +0000 (UTC) Received: (qmail 10093 invoked by alias); 29 Dec 2018 11:08:42 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43954 Received: (qmail 22825 invoked by uid 1010); 29 Dec 2018 11:08:42 -0000 X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25112. spamassassin: 3.4.2. Clear:RC:0(66.111.4.25):SA:0(-2.6/5.0):. Processed in 5.101103 secs); 29 Dec 2018 11:08:42 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=message-id:from:to:cc:mime-version :content-transfer-encoding:content-type:date:references:subject :in-reply-to; s=fm2; bh=L+hi9MgVrMqLrYkVKXCkQ3BYg9zaspJHbdqPHRan VsY=; b=dX/8wzu15VdbEoUrjwdmeyq4/DHdExmXCjLSWoBLEFBt6zZJweILnMae 1nekThTFn8WbTFYp2Ognt5a3YGVsiq/MD4TJDE//BBmkCxBiLw54nX2MIzhmiLTH Yi84bByRNKDkjuIe8k6PlWS8Lzg/RaXIacQC50pyRAU8vkzqwzwi+h1WbT/194La T0oEVkqbJuPPN3ajZvWQqjfnniFnGDbXDm/SANaxlYtoPytEZc8CstGpN0E1jb+i Zh+PgEi9XgMAXg0ib1ktU53T4E3i9xAWCFez7dCqEV21DWLfVGLfmFPG4g90+BNk NUzcXSxMeSP/lSqOWMQWn77BJVtyWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=L+hi9MgVrMqLrYkVKXCkQ3BYg9zaspJHbdqPHRanV sY=; b=d0EwXkaqfCN8F/YOEdAWBmC3zNQNEN21tEOBkkJjD8ZnCsGVy+TL0qOVn XNGLeZ2y60FCl+59fQifVqcRUw4QIYVaNLpK00CYLWaAe5dB/IRrKPPUGYc12pu0 Hp514sgck1B5fjDERA5osV6TnjFPnTDK8ag3951dH7j8gDLUIXAbhV80Pwysm0Xa EgribCBNVPh+V8o5ThgLlTzrWiX4h1bPwyOpFHWEbIVcG7KyquEE3zbVso6Za2He hEi62Tiq4N7jNIn+wXNMPtwSAkVpoaDtbVUgugN8U/Gf55QIa+JkRpiAZ9mWn8wi 5N1wowqWlFlNM3aU7Fy1QZUzSOUyQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrtdekgddvgeculddtuddrgedtkedrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthen uceurghilhhouhhtmecufedttdenucenucfjughrpefkhffvggfgtgfoffhfufgjsehtje ertdertdejnecuhfhrohhmpeffrghnihgvlhcuufhhrghhrghfuceougdrshesuggrnhhi vghlrdhshhgrhhgrfhdrnhgrmhgvqeenucfrrghrrghmpehmrghilhhfrhhomhepugdrsh esuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Message-Id: <1546081711.4142499.1620569296.665048CA@webmail.messagingengine.com> From: Daniel Shahaf To: dana Cc: zsh-workers@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-2f590f9a Date: Sat, 29 Dec 2018 11:08:31 +0000 References: <20181224054021.GK1941@sym.noone.org> <20181224071421.GL1941@sym.noone.org> <1545655545.1499531.1617344072.151563DD@webmail.messagingengine.com> <4E316F0B-5606-4E93-8988-28A5444612E6@dana.is> <20181224170601.i7fiz4zv5fboqtrw@tarpaulin.shahaf.local2> <20181229095516.npdfdskue6yhnrtr@tarpaulin.shahaf.local2> <1546079223.4133547.1620554712.04F681FA@webmail.messagingengine.com> Subject: Re: [PATCH] ztrftime(): Fix truncation for %. In-Reply-To: dana wrote on Sat, 29 Dec 2018 05:02 -0600: > +++ b/Src/utils.c > @@ -3334,19 +3334,28 @@ morefmt: > #endif > switch (*fmt++) { > case '.': > - if (ztrftimebuf(&bufsize, digs)) > - return -1; > + { > if (digs > 9) > digs = 9; > + if (ztrftimebuf(&bufsize, digs)) > + return -1; > + long fnsec = nsec; C89 does not allow defining variables in the middle of a block, so you'll need to move the definition of 'fnsec' to immediately after the opening braces. With that changed, +1. Cheers, Daniel