From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 72a73fae for ; Thu, 3 Jan 2019 12:47:35 +0000 (UTC) Received: (qmail 24110 invoked by alias); 3 Jan 2019 12:47:23 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43969 Received: (qmail 8565 invoked by uid 1010); 3 Jan 2019 12:47:23 -0000 X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25112. spamassassin: 3.4.2. Clear:RC:0(210.118.77.12):SA:0(-9.4/5.0):. Processed in 2.94043 secs); 03 Jan 2019 12:47:23 -0000 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190103124052euoutp02a6557b1c5d5dc87590b83c7b63d0f663~2VxEJGxGP0255402554euoutp02U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1546519252; bh=QVowqRTF18GOxRGBh2CIpqbYPdM7amBMQGX+hUmE9Og=; h=Subject:From:To:Date:In-Reply-To:References:From; b=d2wQrK2BlEniZlJIvI61DZdr1uqr+cnAi6pGpUxG3190+mABoDu+44Z5taAcyvXOF 45A6GKm9b52npMNjFbEfVdywzxcLxLl+TPsKSkLSNCw/SnZ0qdv07QEknL2s6zXEqa 3A9yp4MmFs+KiDg5nv6Y/yh9c7fQLN4hle6P8fXg= X-AuditID: cbfec7f4-835ff700000010c6-46-5c2e02d42d77 Message-ID: <1546519250.4189.10.camel@samsung.com> Subject: Re: Unquoted "-" tokenization broke glob_complete From: Peter Stephenson To: Date: Thu, 3 Jan 2019 12:40:50 +0000 In-Reply-To: <20190103120751.thttr6b3wxzkm5xw@hocevar.net> X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsWy7djPc7pXmPRiDKasY7M42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGT27L7AV7OKqOHpmDWsD4ymOLkZODgkBE4klTw4zdjFycQgJ rGCUWP/0ChuE08ck8ajnIiNIlZBAL5PEugVZMB3HH7VDdSxnlPh69SQThANUNGHpcVYI5zSj RMekWcwQznlGiYONX4AGc3DwChhJXDxYCzJKWMBKYteBqywgNpuAocTUTbPB1okISEpcaz4N ZrMIqEhsf/0CzOYEqm/um8MKcYaGxIabx5hAbF4BQYmTM5+AzWEWkJdo3jobbK+EwHM2ifVd j1kgGlwkZhz/CmULS7w6voUdwpaR+L9zPhNEQzujxJpJr9khnB5GiU1H7zBCVFlL9N0GhQYH 0ApNifW79CHCjhJTt09kBglLCPBJ3HgrCHEEn8SkbdOhwrwSHW1CENVqEjuatjJChGUknq5R mMCoNAvJB7OQfDALYdUCRuZVjOKppcW56anFRnmp5XrFibnFpXnpesn5uZsYgang9L/jX3Yw 7vqTdIhRgINRiYe346BOjBBrYllxZe4hRgkOZiURXrFioBBvSmJlVWpRfnxRaU5q8SFGaQ4W JXHeaoYH0UIC6YklqdmpqQWpRTBZJg5OqQZGUbPXu3xX3TApUCr748n0Qn/5RpW3WezbGSNu Lss9uvWVed22wknvI1/mvbkqFL5cOS6p+/uRDzKhZgrSCY2JR5KKFkvZsk/9qitq4BvNrdVw J1LI4lzm+YtFdyO/P2jqq+2+/njKm+budWHF3feLXsftiTLMXNH4+03txZ+rO9x2le31mMOn xFKckWioxVxUnAgAC5kPbgEDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpikeLIzCtJLcpLzFFi42I5/e/4Pd3LTHoxBv1/uC0ONj9kcmD0WHXw A1MAY5SeTVF+aUmqQkZ+cYmtUrShhZGeoaWFnpGJpZ6hsXmslZGpkr6dTUpqTmZZapG+XYJe Rs/uC2wFu7gqjp5Zw9rAeIqji5GTQ0LAROL4o3bGLkYuDiGBpYwSF1esY4FIyEh8uvKRHcIW lvhzrYsNoqibSeL5tx4WCOc0o8SuR8vYIZzzjBKTTm9n7WLk4OAVMJK4eLAWpFtYwEpi14Gr YFPZBAwlpm6azQhiiwhISlxrPg1mswioSGx//QLM5gSqb+6bwwoxs49R4tKhf6wgCWYBTYnW 7b+hTtKQ2HDzGBOIzSsgKHFy5hMWiBp5ieats5knMArNQtIyC0nZLCRlCxiZVzGKpJYW56bn FhvqFSfmFpfmpesl5+duYgSG/7ZjPzfvYLy0MfgQowAHoxIPr8F+nRgh1sSy4srcQ4wSHMxK IrxixUAh3pTEyqrUovz4otKc1OJDjKZAH01klhJNzgfGZl5JvKGpobmFpaG5sbmxmYWSOO95 g8ooIYH0xJLU7NTUgtQimD4mDk6pBka3slv355340xe1cvbbe6cDJ24MLcyVuv7f1yiQ5238 nl81Jfy8pxq/W37RyjapSJ9dET5jL+uzHysED/ve2x3tLHMzpN/uR9UPk4An94sSNJ1Ki0Wi +p7M2ci2ndfHz5TrT+V53r17r6c52k+f18jCqy8zx1A/z0AvRM9R7kuA5O7dv04K71ZiKc5I NNRiLipOBACyqtshlQIAAA== X-CMS-MailID: 20190103124051eucas1p1a1e785bf7ca864b1d3e5986547e26432 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190103121454epcas3p4e581fa9f1880f6453e1696415bb459a4 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190103121454epcas3p4e581fa9f1880f6453e1696415bb459a4 References: <20190103120751.thttr6b3wxzkm5xw@hocevar.net> On Thu, 2019-01-03 at 13:07 +0100, Sam Hocevar wrote: > Commit f3f8537cfa05414ad14494e809d9ebfeef86ebbc [1] broke autocompletion > when a directory name contains a hyphen and glob_complete is active. You're talking about old-fashioned completion when the shell comes up raw (apart from GLOB_COMPLETE), without the completion system loaded, right? We've been gradually picking up these Dash problems for some time now. It was added to be able to emulate sh pattern matching better, which is irrelevant and (as you've found) occasionally annoying in native mode. I'm seriously wondering if the right fix for such issues in the future isn't simply to give up on complete compatibility for sh-style patterns but just document the issues --- there are things that zsh really isn't equipped to do. pws diff --git a/Src/Zle/compctl.c b/Src/Zle/compctl.c index 87d13af..fe87409 100644 --- a/Src/Zle/compctl.c +++ b/Src/Zle/compctl.c @@ -3256,6 +3256,15 @@ makecomplistflags(Compctl cc, char *s, int incmd, int compadd)   rpl = strlen(rpre);   rsl = strlen(rsuf);      } +    else +    { + for (p = rpre; *p; ++p) +     if (*p == Dash) + *p = '-'; + for (p = rsuf; *p; ++p) +     if (*p == Dash) + *p = '-'; +    }      untokenize(lpre);      untokenize(lsuf);