From: Sven Wischnowsky <wischnow@berkom.de>
To: zsh-workers@sunsite.dk
Subject: Re: zrecompile not verbose enough on failure?
Date: Thu, 7 Mar 2002 09:27:56 +0100 [thread overview]
Message-ID: <15495.9356.955445.827550@wischnow.berkom.de> (raw)
In-Reply-To: <20020306144310.A21102@corelli.new.ox.ac.uk>
Adam Spiers wrote:
> Sven Wischnowsky (wischnow@informatik.hu-berlin.de) wrote:
> > Bart Schaefer wrote:
> >
> > > On Oct 21, 9:42pm, Adam Spiers wrote:
> > > }
> > > } Why does zrecompile redirect STDERR to /dev/null when running
> > > } zcompile?
> > >
> > > Probably to suppress warning-only messages like
> > >
> > > zcompile: functions will use zsh style autoloading
> > >
> > > because zrecompile is intended to run unobtrusively from a .zshrc or the
> > > like; but I agree that it would be nice to see more of the *real* failure
> > > messages from zcompile.
> >
> > Should we make it depend on the -q option?
>
> Yes, that would be nicer than my solution, which was
So, here is my suggestion. Message printing gets a bit confused in
case of errors from zcompile, but personally, I don't care too much.
Bye
Sven
Index: Functions/Misc/zrecompile
===================================================================
RCS file: /cvsroot/zsh/zsh/Functions/Misc/zrecompile,v
retrieving revision 1.8
diff -u -r1.8 zrecompile
--- Functions/Misc/zrecompile 29 May 2001 17:54:39 -0000 1.8
+++ Functions/Misc/zrecompile 7 Mar 2002 08:27:29 -0000
@@ -128,11 +128,13 @@
# If the file is mapped, it might be mapped right now, so keep the
# old file by renaming it.
- if { [[ ! -f $zwc ]] || mv $zwc ${zwc}.old } &&
- zcompile $map $tmp $zwc $files 2> /dev/null; then
- [[ -z $quiet ]] && print succeeded
- else
- [[ -z $quiet ]] && print failed
+ if [[ -z "$quiet" ]] &&
+ { [[ ! -f $zwc ]] || mv $zwc ${zwc}.old } &&
+ zcompile $map $tmp $zwc $files; then
+ print succeeded
+ elif ! { { [[ ! -f $zwc ]] || mv $zwc ${zwc}.old } &&
+ zcompile $map $tmp $zwc $files 2> /dev/null } then
+ [[ -z $quiet ]] && print "re-compiling ${zwc}: failed"
ret=1
fi
fi
@@ -230,10 +232,13 @@
# If the file is mapped, it might be mapped right now, so keep the
# old file by renaming it.
- if mv $zwc ${zwc}.old && zcompile $map $zwc $files 2> /dev/null; then
- [[ -z $quiet ]] && print $mesg
- else
- [[ -z $quiet ]] && print failed
+ if [[ -z "$quiet" ]] &&
+ mv $zwc ${zwc}.old &&
+ zcompile $map $zwc $files; then
+ print $mesg
+ elif ! { mv $zwc ${zwc}.old &&
+ zcompile $map $zwc $files 2> /dev/null } then
+ [[ -z $quiet ]] && print "re-compiling ${zwc}: failed"
ret=1
fi
fi
--
Sven Wischnowsky wischnow@berkom.de
next prev parent reply other threads:[~2002-03-07 8:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-21 20:42 Adam Spiers
2001-10-22 1:59 ` Bart Schaefer
2001-10-22 11:29 ` Sven Wischnowsky
2002-03-06 14:43 ` Adam Spiers
2002-03-07 8:27 ` Sven Wischnowsky [this message]
2002-03-07 11:43 ` Adam Spiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15495.9356.955445.827550@wischnow.berkom.de \
--to=wischnow@berkom.de \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).