From: Sven Wischnowsky <wischnow@berkom.de>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: _netcat
Date: Wed, 13 Mar 2002 09:32:09 +0100 [thread overview]
Message-ID: <15503.3721.373253.225908@wischnow.berkom.de> (raw)
In-Reply-To: <20020312173831.GA30789@logica.com>
Oliver Kiddle wrote:
> ...
>
> Below is a suggested patch which I won't commit without a positive
> reponse first. Any alternate suggestions to the parameter name
> _cmd_variant and the tag name variant particularly welcome. Is it unwise
> to change the existing use of the tag `version' - I'd be suprised
> if anyone has configured this in a style.
1) I like the change because it's more extensible. 2) Can't help you
with a better name, sorry. 3) I don't worry to much about the tag-name
change either.
> ...
>
> local expl curcontext="$curcontext" state line codeset LOCPATH
>
> -(( $+_is_gnu )) || typeset -gA _is_gnu
> -if (( ! $+_is_gnu[$words[1]] )); then
> - if [[ $(_call_program version $words[1] --version </dev/null 2>/dev/null) = *GNU* ]];
> +(( $+_cmd_variant )) || typeset -gA _cmd_variant
> +if (( ! $+_cmd_variant[$words[1]] )); then
> + if [[ $(_call_program variant $words[1] --version </dev/null 2>/dev/null) = *GNU* ]];
> then
> - _is_gnu[$words[1]]=yes
> + _cmd_variant[$words[1]]=gnu
> else
> - _is_gnu[$words[1]]=
> + _cmd_variant[$words[1]]=
> fi
> fi
Hm, some kind of helper-function for this?
> -if [[ -n "$_is_gnu[$words[1]]" ]]; then
> +if [[ -n "$_cmd_variant[$words[1]]" ]]; then
I'm confused. Shoudn't this test `"$_cmd_variant[$words[1]]" = gnu'?
As you do in:
> ...
> + [[ $_cmd_variant[$words[1]] = nedit ]] && _nedit
And, btw., on this Suse-box:
% which netcat
/usr/bin/netcat
And nc is the nedit-thing. (You asked for this, right? OR was it
someone else?)
Bye
Sven
--
Sven Wischnowsky wischnow@berkom.de
next prev parent reply other threads:[~2002-03-13 8:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-10 22:25 Bart Schaefer
2002-03-11 11:26 ` Oliver Kiddle
2002-03-12 17:38 ` Oliver Kiddle
2002-03-13 8:32 ` Sven Wischnowsky [this message]
2002-03-14 12:22 ` Oliver Kiddle
2002-03-15 8:39 ` Sven Wischnowsky
2002-03-15 16:06 ` Oliver Kiddle
2002-03-15 16:45 ` Bart Schaefer
2002-03-20 9:23 ` Sven Wischnowsky
-- strict thread matches above, loose matches on Subject: below --
2002-03-10 4:17 Clint Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15503.3721.373253.225908@wischnow.berkom.de \
--to=wischnow@berkom.de \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).