From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 271e1b18 for ; Mon, 25 Mar 2019 12:43:08 +0000 (UTC) Received: (qmail 11637 invoked by alias); 25 Mar 2019 12:42:55 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44174 Received: (qmail 8267 invoked by uid 1010); 25 Mar 2019 12:42:55 -0000 X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.1/25398. spamassassin: 3.4.2. Clear:RC:0(210.118.77.12):SA:0(-7.0/5.0):. Processed in 3.378848 secs); 25 Mar 2019 12:42:55 -0000 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.samsung.com designates 210.118.77.12 as permitted sender) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190325124216euoutp027c355adf83c11fd456d95ae554c6ee83~PNCaKm1nh3109831098euoutp02W DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1553517736; bh=fdI/mTCYWwRnWarq6e9a1X85GW46QLng3DcOgmPgaEQ=; h=Subject:From:To:Date:In-Reply-To:References:From; b=XiQjxdXITJ1mUf99L1CedEYEijrMQHJLTdlh1QF/Dofh+Uk5ruI3nz1B7qsftYUuq wfceyPy93suD5psu7SflefEwv8wT8uU6BeLPAHid2xkFUnpJ60BvxNjwVhJPxdZScm gkB5EoLhPk8jKVYmo8Znk0+SxNd5t4Sw6AXf6zUM= X-AuditID: cbfec7f4-12dff70000001119-5b-5c98cca77858 Message-ID: <1553517734.6561.2.camel@samsung.com> Subject: Re: [PATCH] Change handrolled strftime to strftime in zftp.c From: Peter Stephenson To: Date: Mon, 25 Mar 2019 12:42:14 +0000 In-Reply-To: X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsWy7djP87rLz8yIMZjUa2RxsPkhkwOjx6qD H5gCGKO4bFJSczLLUov07RK4Mu683MVU0MtScXb6AeYGxrXMXYycHBICJhIz9uxiAbGFBFYw SmzZEd7FyAVk9zFJnJm5iw3C6WWS2NU4gR2m4/iD3UwQieWMEg+Wn2aCqzrxrR3KOcMosXjC YijnAqPE664VjCD9vAKGEpMOXmICsYUFXCWWNM9jA7HZgOJTN80GqxERkJS41nwazGYRUJXY dPwc2G5OoPqLP76xQdyhIbHh5jEmiJmCEidnPgH7gllAXqJ562xmkMUSArfZJF5sbAMq4gBy XCS2fXKE6BWWeHV8C9Q/MhL/d85ngqhvZ5RYM+k1O4TTwyix6egdRogqa4m+2xcZQQYxC2hK rN+lDxF2lJj4/jsbxHw+iRtvBSFu4JOYtG06M0SYV6KjTQiiWk1iR9NWRoiwjMTTNQoTGJVm IXlgFpIHZiGsWsDIvIpRPLW0ODc9tdgoL7Vcrzgxt7g0L10vOT93EyMwFZz+d/zLDsZdf5IO MQpwMCrx8BYcnxEjxJpYVlyZe4hRgoNZSYT3iShQiDclsbIqtSg/vqg0J7X4EKM0B4uSOG81 w4NoIYH0xJLU7NTUgtQimCwTB6dUA6Ni+fMlB3kP9kyr7JjfragZHLrLUSmuuttrrcPsng2B F9U8Aq9OZmU+euzoX52gBc0Pd708l2nWFXSPW29BlIHb3E3RVa3aNVJP2jv2/u2dmb0+u59J 96LigSyBrO92gs3tn7rrY3IjmxNmz2RhvPlb4J1q0h6l7w1PHguUu/zOst7EyHK5RYmlOCPR UIu5qDgRAJRjJRwBAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmkeLIzCtJLcpLzFFi42I5/e/4Xd1lZ2bEGFw9bm1xsPkhkwOjx6qD H5gCGKP0bIryS0tSFTLyi0tslaINLYz0DC0t9IxMLPUMjc1jrYxMlfTtbFJSczLLUov07RL0 Mu683MVU0MtScXb6AeYGxrXMXYycHBICJhLHH+xm6mLk4hASWMoosf/0LiaIhIzEpysf2SFs YYk/17rYIIq6mSQ2P1wG5ZxhlFiw7igjhHOBUeLOhXtgc3kFDCUmHbwENkpYwFViSfM8NhCb DSg+ddNsRhBbREBS4lrzaTCbRUBVYtPxc2DrOIHqL/74BrXhK6PE1I0nwZqZBTQlWrf/hrpJ Q2LDzWNMEMsEJU7OfMICUSMv0bx1NvMERqFZSFpmISmbhaRsASPzKkaR1NLi3PTcYkO94sTc 4tK8dL3k/NxNjMAI2Hbs5+YdjJc2Bh9iFOBgVOLhLTg+I0aINbGsuDL3EKMEB7OSCO8TUaAQ b0piZVVqUX58UWlOavEhRlOgjyYyS4km5wOjM68k3tDU0NzC0tDc2NzYzEJJnPe8QWWUkEB6 YklqdmpqQWoRTB8TB6dUA2PQwvVNH50/ez7mPaseIMSmmNUYV6Gv0vS7V/4l4400rXrJw+9q v3tYOrQeP/2pO/dvBKPntfRdT9lMN7F/Pn7lL+cMh8hrm245PZjd49QbFy728cS8LeaJ7ItV D3llNZ1tkVdPVd7586aw4+kH8cappgcLZc3Xz7BMDSm8trCrWS27YB7LHiWW4oxEQy3mouJE ABorKpiWAgAA X-CMS-MailID: 20190325124215eucas1p1750a00d96767f59ea37a16df248ea9f5 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190325121427epcas4p18e794aebecc4f574c6abc701a2080eba X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190325121427epcas4p18e794aebecc4f574c6abc701a2080eba References: <20190323101135.14344-1-wesley@mintlab.nl> <20190323101135.14344-2-wesley@mintlab.nl> On Mon, 2019-03-25 at 21:13 +0900, Jun T wrote: > #ifdef OFF_T_IS_64_BIT >         printf("%s %s\n", output64(sz), mt); > #else >         DPUTS(sizeof(sz) > 4, "Shell compiled with wrong off_t size"); >         printf("%ld %s\n", (long)sz, mt); > #endif >  >  > Should we replace "#ifdef OFF_T_IS_64_BIT" by "#ifndef OFF_T_IS_64_BIT"? The obvious test would be #ifdef ZSH_64_BIT_TYPE which is how we know output64 is defined.  That's used in some other case. Cheers pws