From: Peter Stephenson <p.stephenson@samsung.com>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: [PATCH] Change handrolled strftime to strftime in zftp.c
Date: Mon, 25 Mar 2019 15:08:17 +0000 [thread overview]
Message-ID: <1553526497.6561.3.camel@samsung.com> (raw)
In-Reply-To: <1164333478.906060.1553524596824@mail2.virginmedia.com>
On Mon, 2019-03-25 at 14:36 +0000, Peter Stephenson wrote:
> >
> > On 25 March 2019 at 13:07 "Jun T." <takimoto-j@kba.biglobe.ne.jp> wrote:
> > >
> > > 2019/03/25 21:42, Peter Stephenson <p.stephenson@samsung.com> wrote:
> > > >
> > > >
> > > > Should we replace "#ifdef OFF_T_IS_64_BIT" by "#ifndef OFF_T_IS_64_BIT"?
> > > The obvious test would be
> > >
> > > #ifdef ZSH_64_BIT_TYPE
> > But ZSH_64_BIT_TYPE is defined only if long is 32 bit
> > so we still get 'Shell compiled with wrong off_t size'.
> > Do you mean "#ifndef ZSH_64_BIT_TYPE"?
> I don't see how that could work since output64() wouldn't exist.
>
> I think this means the error message in the other branch is now
> redundant --- if long is a 64-bit value it's perfectly OK to use that
> code. Could change the DPUTS check to check sizeof(sz) for that
> purpose instead?
...which you've now done, so this should be fine.
pws
prev parent reply other threads:[~2019-03-25 15:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 10:11 [PATCH 0/1] Fix -Wformat-overflow= warnings " Wesley Schwengle
2019-03-23 10:11 ` [PATCH] Change handrolled strftime to strftime " Wesley Schwengle
2019-03-25 12:13 ` Jun T
2019-03-25 12:42 ` Peter Stephenson
2019-03-25 13:07 ` Jun T.
2019-03-25 13:32 ` Jun T.
2019-03-25 14:36 ` Peter Stephenson
2019-03-25 15:06 ` Jun T.
2019-03-25 15:08 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553526497.6561.3.camel@samsung.com \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).