zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: Proposal (with code) to fix breaking of history widgets on reset-prompt
Date: Wed, 10 Apr 2019 08:46:05 +0000	[thread overview]
Message-ID: <1554885965.6252.2.camel@samsung.com> (raw)
In-Reply-To: <CAN=4vMrw_z+wzgwjQad1bi4+SOf=PB2_V2t2os+wx-PvCgQdsQ@mail.gmail.com>

On Tue, 2019-04-09 at 20:45 +0200, Roman Perepelitsa wrote:
> On Thu, Mar 28, 2019 at 12:21 PM Peter Stephenson <p.stephenson@samsung.com> wrote:
> > Don't see any problem with doing that.  I suppose we really need a
> > list of widgets that should have this behaviour.
> > 
> > [...]
> > 
> > If you can produce this as a single change (with appropriate use of
> > rebase -i or whatever) we can apply it.  A patch to the list would be
> > fine, since other people get to see it, but I don't mind cherry-picking
> > / rebasing from your repo if it's a single squashed change somewhere.
> Cool! I can do that.
> 
> Here's a branch with a single commit that modifies reset-prompt so that it
> doesn't alter
> LASTWIDGET: https://github.com/zsh-users/zsh/compare/master...romkatv:gentle-reset-prompt2. 
> 
> Please find a patch from it in the attachment.

Thanks, I've applied this.

pws

  reply	other threads:[~2019-04-10  8:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190323131052epcas1p4ee9c963395adaa3c2bb560e1a290f6bd@epcas1p4.samsung.com>
2019-03-23 13:09 ` Roman Perepelitsa
2019-03-28 11:20   ` Peter Stephenson
2019-04-09 18:45     ` Roman Perepelitsa
2019-04-10  8:46       ` Peter Stephenson [this message]
2019-04-10  8:51         ` Roman Perepelitsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1554885965.6252.2.camel@samsung.com \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).