From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 42f473fe for ; Wed, 10 Apr 2019 08:48:51 +0000 (UTC) Received: (qmail 28777 invoked by alias); 10 Apr 2019 08:48:40 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44218 Received: (qmail 86 invoked by uid 1010); 10 Apr 2019 08:48:40 -0000 X-Qmail-Scanner-Diagnostics: from mailout1.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.1/25412. spamassassin: 3.4.2. Clear:RC:0(210.118.77.11):SA:0(-7.0/5.0):. Processed in 1.604834 secs); 10 Apr 2019 08:48:40 -0000 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.samsung.com designates 210.118.77.11 as permitted sender) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190410084804euoutp014bbc57471c05839a85df99d81deff29d~UEKf2c-a62392023920euoutp01K DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1554886084; bh=AFzF1I7N9vciIPXOWHq93HptG3j/Fh0A4ir12YpjCYs=; h=Subject:From:To:Date:In-Reply-To:References:From; b=E/a0tTCtEK1HVe2bEiHK/TOWF5jqbUtX8fmas5W5p2+hFDqTwB1pXUJ7uWpyDPnMa 9Md2E3muotRD2+2+cJpGPVwcPHmLt7oBR1CzFuf6GkV0wz7lHjPXQcFJl4Z/LlL+97 I4bl1MMxybVYVlwSR6rVrbH0/WPCCoFDDF60YRqQ= X-AuditID: cbfec7f4-12dff70000001119-77-5cadadc46ab4 Message-ID: <1554886082.6252.3.camel@samsung.com> Subject: Re: -Wrestrict warning on cc 8.3.0 From: Peter Stephenson To: Date: Wed, 10 Apr 2019 09:48:02 +0100 In-Reply-To: <1554373291.5874.3.camel@samsung.com> X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsWy7djPc7pH1q6NMZjXzGdxsPkhkwOjx6qD H5gCGKO4bFJSczLLUov07RK4Mma1n2Iq+MBVMWXRdvYGxg8cXYycHBICJhK9f26zdTFycQgJ rGCU+Hr+PxOE08ck0Xj+GZTTyyQxecV3NpiWN4t/MkMkljNKfFjbywKSAKu6soMVInGGUWLW k5dQVRcYJTafWscKUsUrYCixYd17dhBbWEBb4vCGGYwgNhtQfOqm2WC2iICkxLXm02A2i4Cq xNsHl8FWcwoYSbz8eZ8J4gwNiQ03jzFBzBSUODnzCdgVzALyEs1bZ4MtlhC4zyax5c1RqAYX iUd3m6F+EJZ4dXwLO4QtI/F/53wmiIZ2Rok1k16zQzg9jBKbjt5hhKiylui7fRHI5gBaoSmx fpc+iCkh4Cix9wo3hMknceOtIMQNfBKTtk1nhgjzSnS0CUHMUJPY0bSVESIsI/F0jcIERqVZ SB6YheSBWQibFjAyr2IUTy0tzk1PLTbKSy3XK07MLS7NS9dLzs/dxAhMBaf/Hf+yg3HXn6RD jAIcjEo8vBHz1sQIsSaWFVfmHmKU4GBWEuH9+AYoxJuSWFmVWpQfX1Sak1p8iFGag0VJnLea 4UG0kEB6YklqdmpqQWoRTJaJg1OqgbEu8P7a5ikZ0pPt8zbtu1HjV+vfoySybvXN2Phtb89W V61sK2bcVqNgXR7y4PVUp84aA7Mwpnir9XtnHW1aulth992aOR23lqVdfDE1W70maoKN8QQz CTaD2ANHtAtsj1TVL9nau/ve5OeqZV8u7xcwmNE6X6pRPuotm8CtjzFGnGubpAK28SmxFGck GmoxFxUnAgAs66IyAQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpikeLIzCtJLcpLzFFi42I5/e/4Xd3Da9fGGCyYI2lxsPkhkwOjx6qD H5gCGKP0bIryS0tSFTLyi0tslaINLYz0DC0t9IxMLPUMjc1jrYxMlfTtbFJSczLLUov07RL0 Mma1n2Iq+MBVMWXRdvYGxg8cXYycHBICJhJvFv9k7mLk4hASWMoosevgWlaIhIzEpysf2SFs YYk/17rYIIq6mSTmnPjABOGcYZS4vX0KVOYCo8TqhSsYQVp4BQwlNqx7D9YuLKAtcXjDDLA4 G1B86qbZYLaIgKTEtebTYDaLgKrE2weX2UBsTgEjiZc/7zOB2EIC5xgl3r3XA7GZBTQlWrf/ hjpJQ2LDzWNMELsEJU7OfMICUSMv0bx1NvMERqFZSFpmISmbhaRsASPzKkaR1NLi3PTcYkO9 4sTc4tK8dL3k/NxNjMDw33bs5+YdjJc2Bh9iFOBgVOLhDZi+JkaINbGsuDL3EKMEB7OSCO/H N0Ah3pTEyqrUovz4otKc1OJDjKZAD01klhJNzgfGZl5JvKGpobmFpaG5sbmxmYWSOO95g8oo IYH0xJLU7NTUgtQimD4mDk6pBkargEB+d7s/V768Ln3W/zv28amjMo/3WXtftW+Ord64P1hm QV1VZjwf934Wf99J+zetmtUpcN+wXl26WOb1ii2n5V/Nfj13WbD28hdmVkFH67Kt3J2iu/1Z W+7EpYk69a3wT5lmdGN9jBTzjfciGe+kVsst3zO/r/ROY3a/pVXjOZsA8U8fBZVYijMSDbWY i4oTAYkFZAqVAgAA X-CMS-MailID: 20190410084803eucas1p27a784f362bd542314046f5d0543a73b7 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190403190049epcas3p4c02406857f7f26510ea8969c969a655e X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190403190049epcas3p4c02406857f7f26510ea8969c969a655e References: <1554373291.5874.3.camel@samsung.com> On Thu, 2019-04-04 at 11:21 +0100, Peter Stephenson wrote: > On Wed, 2019-04-03 at 20:59 +0200, Wesley Schwengle wrote: > >  > > During a make of the latest master I got the following warning: > >   > > gcc -c -I. -I../../Src -I../../Src -I../../Src/Zle -I.  -DHAVE_CONFIG_H > > -DMODULE -Wall -Wmissing-prototypes -O2 -fPIC -o compctl..o compctl.c > > compctl.c: In function ‘makecomplistflags.isra.6’: > > compctl.c:3340:7: warning: ‘strcpy’ accessing 1 byte at offsets [0, > > 9223372036854775807] and [0,9223372036854775807] may overlap 1 byte at > > offset 0 [-Wrestrict] > > strcpy(p, p + bl); > > ^~~~~~~~~~~~~~~~~ > > rm -f compctl.so > This warning is thoroughly opaque --- and not occurring with a locally > compiled gcc 8.3.0 on my Ubuntu 16.04 64-bit Intel system --- but the > code isn't exactly crystal clear, either (subtracting a number off then > adding it immediately back on again isn't generally regarded as great > style), and it's quite possible the copy is overlapping.  Also, the last > person to worry about code optimisation in compctl emigrated to the > Undying Lands a decade ago (maybe I can still find the postcard...) >  > Can somebody verify the following is equivalent apart from dealing with > a possible overlapping copy?  I've no way of ensuring this code gets > exercised.  I've applied this anyway. pws