new valgrind errors

new valgrind errors

[Felix Rosencrantz]

Here is condensed output based on the latest changes.  -FR.
 ERROR SUMMARY: 1537 errors from 12 contexts (suppressed: 24 from 1)
 
 11 errors in context 1 of 12:
 Invalid read of size 4
    at 0x80A49C3: pattryrefs (pattern.c:1357)
    by 0x80A4952: pattry (pattern.c:1331)
    by 0x413B1E39: lookupstyle (zutil.c:247)
    by 0x413B27C4: bin_zstyle (zutil.c:439)
    Address 0x4105951C is 20 bytes inside a block of size 80 free'd
    at 0x40040311: free (vg_clientfuncs.c:156)
    by 0x808C737: zfree (mem.c:1391)
    by 0x80A7229: freepatprog (pattern.c:2326)
    by 0x413B1912: setstypat (zutil.c:135)
 
 11 errors in context 3 of 12:
 Invalid read of size 4
    at 0x80A49A5: pattryrefs (pattern.c:1356)
    by 0x80A4952: pattry (pattern.c:1331)
    by 0x413B1E39: lookupstyle (zutil.c:247)
    by 0x413B27C4: bin_zstyle (zutil.c:439)
    Address 0x4105951C is 20 bytes inside a block of size 80 free'd
    at 0x40040311: free (vg_clientfuncs.c:156)
    by 0x808C737: zfree (mem.c:1391)
    by 0x80A7229: freepatprog (pattern.c:2326)
    by 0x413B1912: setstypat (zutil.c:135)
 
 11 errors in context 4 of 12:
 Invalid read of size 4
    at 0x80A4969: pattryrefs (pattern.c:1344)
    by 0x80A4952: pattry (pattern.c:1331)
    by 0x413B1E39: lookupstyle (zutil.c:247)
    by 0x413B27C4: bin_zstyle (zutil.c:439)
    Address 0x41059508 is 0 bytes inside a block of size 80 free'd
    at 0x40040311: free (vg_clientfuncs.c:156)
    by 0x808C737: zfree (mem.c:1391)
    by 0x80A7229: freepatprog (pattern.c:2326)
    by 0x413B1912: setstypat (zutil.c:135)
 
 253 errors in context 9 of 12:
 Invalid read of size 1
    at 0x4004097C: strcmp (vg_clientfuncs.c:405)
    by 0x80A4A02: pattryrefs (pattern.c:1357)
    by 0x80A4952: pattry (pattern.c:1331)
    by 0x413B1E39: lookupstyle (zutil.c:247)
    Address 0x4105952C is 36 bytes inside a block of size 80 free'd
    at 0x40040311: free (vg_clientfuncs.c:156)
    by 0x808C737: zfree (mem.c:1391)
    by 0x80A7229: freepatprog (pattern.c:2326)
    by 0x413B1912: setstypat (zutil.c:135)
 
 264 errors in context 10 of 12:
 Invalid read of size 1
    at 0x4004096F: strcmp (vg_clientfuncs.c:404)
    by 0x80A4A02: pattryrefs (pattern.c:1357)
    by 0x80A4952: pattry (pattern.c:1331)
    by 0x413B1E39: lookupstyle (zutil.c:247)
    Address 0x4105952C is 36 bytes inside a block of size 80 free'd
    at 0x40040311: free (vg_clientfuncs.c:156)
    by 0x808C737: zfree (mem.c:1391)
    by 0x80A7229: freepatprog (pattern.c:2326)
    by 0x413B1912: setstypat (zutil.c:135)
 
 IN SUMMARY: 1537 errors from 12 contexts (suppressed: 24 from 1)
 
 malloc/free: in use at exit: 413418 bytes in 12144 blocks.
 malloc/free: 30481 allocs, 18337 frees, 2852021 bytes allocated.
 
 searching for pointers to 12144 not-freed blocks.
 checked 6280660 bytes.
 
 definitely lost: 2680 bytes in 57 blocks.
 possibly lost:   0 bytes in 0 blocks.
 still reachable: 410738 bytes in 12087 blocks.
 
 80 bytes in 1 blocks are definitely lost in loss record 8 of 27
    at 0x4004009E: malloc (vg_clientfuncs.c:96)
    by 0x808C15E: zalloc (mem.c:490)
    by 0x80A2C58: patcompile (pattern.c:436)
    by 0x413B1FE1: bin_zstyle (zutil.c:293)



__________________________________________________
Do You Yahoo!?
Yahoo! Games - play chess, backgammon, pool and more
http://games.yahoo.com/

Re: new valgrind errors

[Felix Rosencrantz]

As a side question...  I don't really understand enough about how autoconf and
configure work and how to get particular compiler flags.

I was trying to build zsh with a "-g" flag.  I tried using the --enable-debug
flag.  But that seemed to add the "-ggdb" flag, which isn't same.  Is there a
way to get the plain "-g" flag via configure.

-FR.
--- Felix Rosencrantz <f_rosencrantz@yahoo.com> wrote:
> Here is condensed output based on the latest changes.  -FR.


__________________________________________________
Do You Yahoo!?
Yahoo! Games - play chess, backgammon, pool and more
http://games.yahoo.com/

RE: new valgrind errors

[Borsenkow Andrej]

> As a side question...  I don't really understand enough about how
autoconf
> and
> configure work and how to get particular compiler flags.
> 
> I was trying to build zsh with a "-g" flag.  I tried using the
--enable-
> debug
> flag.  But that seemed to add the "-ggdb" flag, which isn't same.  Is
there
> a
> way to get the plain "-g" flag via configure.
> 

CFLAGS=-g configure ...

Does not it work?

-andrej

Re: new valgrind errors

[Sven Wischnowsky]

Felix Rosencrantz wrote:

> Here is condensed output based on the latest changes.  -FR.
>  ERROR SUMMARY: 1537 errors from 12 contexts (suppressed: 24 from 1)
>  
>  11 errors in context 1 of 12:
>  Invalid read of size 4
>     at 0x80A49C3: pattryrefs (pattern.c:1357)
>     by 0x80A4952: pattry (pattern.c:1331)
>     by 0x413B1E39: lookupstyle (zutil.c:247)
>     by 0x413B27C4: bin_zstyle (zutil.c:439)
>     Address 0x4105951C is 20 bytes inside a block of size 80 free'd
>     at 0x40040311: free (vg_clientfuncs.c:156)
>     by 0x808C737: zfree (mem.c:1391)
>     by 0x80A7229: freepatprog (pattern.c:2326)
>     by 0x413B1912: setstypat (zutil.c:135)

Argh. That part of the patch was a thinko. Re-fix below.

But then I don't see how the original error came to pass.


Bye
  Sven

Index: Src/Modules/zutil.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/zutil.c,v
retrieving revision 1.10
diff -u -r1.10 zutil.c
--- Src/Modules/zutil.c	24 Apr 2002 07:59:19 -0000	1.10
+++ Src/Modules/zutil.c	25 Apr 2002 07:29:24 -0000
@@ -132,7 +132,6 @@
 		freearray(p->vals);
 	    if (p->eval)
 		freeeprog(p->eval);
-            freepatprog(p->prog);
 	    p->vals = zarrdup(vals);
 	    p->eval = eprog;
 

-- 
Sven Wischnowsky                          wischnow@berkom.de